Skip to content

Commit 0a77abd

Browse files
committed
Updated to latest
1 parent 532846c commit 0a77abd

File tree

2 files changed

+27
-58
lines changed

2 files changed

+27
-58
lines changed

CodeEdit/Features/InspectorArea/Views/InspectorAreaView.swift

Lines changed: 13 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,24 @@ struct InspectorAreaView: View {
1313
@ObservedObject private var extensionManager = ExtensionManager.shared
1414
@ObservedObject public var viewModel: InspectorAreaViewModel
1515

16-
@EnvironmentObject private var editorManager: EditorManager
17-
18-
@AppSettings(\.sourceControl.general.sourceControlIsEnabled)
19-
private var sourceControlIsEnabled: Bool
20-
2116
@AppSettings(\.general.inspectorTabBarPosition)
2217
var sidebarPosition: SettingsData.SidebarTabBarPosition
2318

2419
init(viewModel: InspectorAreaViewModel) {
2520
self.viewModel = viewModel
26-
updateTabItems()
21+
22+
viewModel.tabItems = [.file, .gitHistory] +
23+
extensionManager
24+
.extensions
25+
.map { ext in
26+
ext.availableFeatures.compactMap {
27+
if case .sidebarItem(let data) = $0, data.kind == .inspector {
28+
return InspectorTab.uiExtension(endpoint: ext.endpoint, data: data)
29+
}
30+
return nil
31+
}
32+
}
33+
.joined()
2734
}
2835

2936
var body: some View {
@@ -36,28 +43,5 @@ struct InspectorAreaView: View {
3643
.formStyle(.grouped)
3744
.accessibilityElement(children: .contain)
3845
.accessibilityLabel("inspector")
39-
.onChange(of: sourceControlIsEnabled) { _ in
40-
updateTabItems()
41-
}
42-
}
43-
44-
private func updateTabItems() {
45-
viewModel.tabItems = [.file] +
46-
(sourceControlIsEnabled ? [.gitHistory] : []) +
47-
extensionManager
48-
.extensions
49-
.flatMap { ext in
50-
ext.availableFeatures.compactMap {
51-
if case .sidebarItem(let data) = $0, data.kind == .inspector {
52-
return InspectorTab.uiExtension(endpoint: ext.endpoint, data: data)
53-
}
54-
return nil
55-
}
56-
}
57-
if let selectedTab = selection,
58-
!viewModel.tabItems.isEmpty &&
59-
!viewModel.tabItems.contains(selectedTab) {
60-
selection = viewModel.tabItems[0]
61-
}
6246
}
6347
}

CodeEdit/Features/NavigatorArea/Views/NavigatorAreaView.swift

Lines changed: 14 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,22 @@ struct NavigatorAreaView: View {
1515
@AppSettings(\.general.navigatorTabBarPosition)
1616
var sidebarPosition: SettingsData.SidebarTabBarPosition
1717

18-
@AppSettings(\.sourceControl.general.sourceControlIsEnabled)
19-
private var sourceControlIsEnabled: Bool
20-
21-
init(workspace: WorkspaceDocument, viewModel: NavigatorSidebarViewModel) {
18+
init(workspace: WorkspaceDocument, viewModel: NavigatorAreaViewModel) {
2219
self.workspace = workspace
2320
self.viewModel = viewModel
24-
updateTabItems()
21+
22+
viewModel.tabItems = [.project, .sourceControl, .search] +
23+
extensionManager
24+
.extensions
25+
.map { ext in
26+
ext.availableFeatures.compactMap {
27+
if case .sidebarItem(let data) = $0, data.kind == .navigator {
28+
return NavigatorTab.uiExtension(endpoint: ext.endpoint, data: data)
29+
}
30+
return nil
31+
}
32+
}
33+
.joined()
2534
}
2635

2736
var body: some View {
@@ -34,29 +43,5 @@ struct NavigatorAreaView: View {
3443
.environmentObject(workspace)
3544
.accessibilityElement(children: .contain)
3645
.accessibilityLabel("navigator")
37-
.onChange(of: sourceControlIsEnabled) { _ in
38-
updateTabItems()
39-
}
40-
}
41-
42-
private func updateTabItems() {
43-
viewModel.tabItems = [.project] +
44-
(sourceControlIsEnabled ? [.sourceControl] : []) +
45-
[.search] +
46-
extensionManager
47-
.extensions
48-
.flatMap { ext in
49-
ext.availableFeatures.compactMap {
50-
if case .sidebarItem(let data) = $0, data.kind == .navigator {
51-
return NavigatorTab.uiExtension(endpoint: ext.endpoint, data: data)
52-
}
53-
return nil
54-
}
55-
}
56-
if let selectedTab = viewModel.selectedTab,
57-
!viewModel.tabItems.isEmpty &&
58-
!viewModel.tabItems.contains(selectedTab) {
59-
viewModel.selectedTab = viewModel.tabItems[0]
60-
}
6146
}
6247
}

0 commit comments

Comments
 (0)