Skip to content

Fix Situationally Unusable Tab Groups #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecoolwinter merged 1 commit into from
Jul 1, 2023
Merged

Fix Situationally Unusable Tab Groups #1364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CodeEdit/Features/Tabs/TabGroup/TabGroupData.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ final class TabGroupData: ObservableObject, Identifiable {
/// This will also write any changes to the file on disk and will add the tab to the tab history.
/// - Parameter item: the tab to close.
func closeTab(item: Tab) {
if temporaryTab == item {
temporaryTab = nil
}

historyOffset = 0
if item != selected {
history.prepend(item)
Expand Down Expand Up @@ -200,7 +204,6 @@ final class TabGroupData: ObservableObject, Identifiable {
)
item.fileDocument = codeFile
CodeEditDocumentController.shared.addDocument(codeFile)
print("Opening file for item: ", item.url)
}

func goBackInHistory() {
Expand Down