Skip to content

Conversation

@KhadijaMahanga
Copy link
Contributor

@KhadijaMahanga KhadijaMahanga commented Feb 4, 2021

Description

Add online/offline nodes count to META
Screenshot from 2021-02-04 08-27-58

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾 @KhadijaMahanga


  1. I think lets just do one i.e. active or inactive but not both, and
  2. Lets change the nodes prop to an object like
  ....
  "nodes": {
   "active": get_active_nodes(),
    "count": nodes_count,
  },
  ....

Copy link
Contributor

@esirK esirK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhadijaMahanga KhadijaMahanga merged commit 6932fae into master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants