Adding Casbin for User Roles #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add userRoles back into the API and create a default admin role. resolves #100
We are using Casbin to administer user roles and privvies. This work will add Casbin integration as well as Casbin/Sequelize integration. This includes model, migrate, and seeder. Additionally we are adding brute force protections with this PR. resolves #100
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 69.31% 68.94% -0.37%
==========================================
Files 14 15 +1
Lines 378 454 +76
==========================================
+ Hits 262 313 +51
- Misses 116 141 +25
Continue to review full report at Codecov.
|
Member
Author
|
@allcontributors add @blakenan-bellese for ideas |
Contributor
|
@revjtanton I've put up a pull request to add @blakenan-bellese! 🎉 |
…ore-Responsive into revjtanton/issue-100
c-w-allen
reviewed
Apr 27, 2020
| @@ -1,6 +1,73 @@ | |||
| [ | |||
| { | |||
| "role": "admin", | |||
Contributor
There was a problem hiding this comment.
Is there an easier way to just let an admin do everything here? Just curious
Member
Author
There was a problem hiding this comment.
Unfortunately from what I've seen with Casbin you cannot wildcard the method, it has to be explicit.
c-w-allen
reviewed
Apr 27, 2020
c-w-allen
previously approved these changes
Apr 29, 2020
… moving limiting to middleware decl
…ore-Responsive into revjtanton/issue-100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using Casbin to administer user roles and privvies. This work
will add Casbin integration as well as Casbin/Sequelize integration.
This includes model, migrate, and seeder.
Additionally we are adding brute force protections with this PR.
resolves #100
resolves #101
Todos
Deploy Notes
This will require a re-creation and re-seeding of the db.
Impacted Areas in Application
List general components of the application that this PR will affect: