Skip to content

Conversation

@stoopidJSON
Copy link
Member

@stoopidJSON stoopidJSON commented Apr 27, 2020

A major refactor to add many-to-many functionality for contacts.
resolves #121
resolves #133

Todos

  • Tests
  • Documentation
  • Adjust seeding

Impacted Areas in Application

List general components of the application that this PR will affect:

  • contacts
  • entities

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #130 into master will decrease coverage by 4.58%.
The diff coverage is 25.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   68.94%   64.35%   -4.59%     
==========================================
  Files          15       16       +1     
  Lines         454      505      +51     
==========================================
+ Hits          313      325      +12     
- Misses        141      180      +39     
Impacted Files Coverage Δ
src/routes/entity.js 31.57% <4.76%> (-6.13%) ⬇️
src/routes/contact.js 33.82% <12.50%> (-12.01%) ⬇️
src/models/entity-contact.js 60.00% <60.00%> (ø)
src/models/contact.js 76.47% <75.00%> (-2.11%) ⬇️
src/models/entity.js 70.58% <75.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff8af0...72a5a4f. Read the comment docs.

@stoopidJSON stoopidJSON marked this pull request as draft April 27, 2020 14:47
@c-w-allen c-w-allen force-pushed the seancrim23/issue-121 branch 8 times, most recently from 56f531f to d0853a0 Compare April 29, 2020 16:52
Sean Crim and others added 8 commits April 29, 2020 12:57
@c-w-allen c-w-allen force-pushed the seancrim23/issue-121 branch from d0853a0 to 4be2524 Compare April 29, 2020 16:57
@c-w-allen c-w-allen marked this pull request as ready for review April 29, 2020 16:57
@c-w-allen c-w-allen force-pushed the seancrim23/issue-121 branch from a2ff3b5 to 7646eed Compare April 30, 2020 22:22
@c-w-allen
Copy link
Contributor

This should also now close #133

@stoopidJSON
Copy link
Member Author

@allcontributors add @c-w-allen for code

@allcontributors
Copy link
Contributor

@revjtanton

I've put up a pull request to add @c-w-allen! 🎉

@stoopidJSON stoopidJSON merged commit 82f6702 into master May 1, 2020
@stoopidJSON stoopidJSON deleted the seancrim23/issue-121 branch May 1, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link entities/contacts on creation endpoint Many to many entities and contacts

3 participants