Skip to content

Conversation

@c-w-allen
Copy link
Contributor

@c-w-allen c-w-allen commented May 5, 2020

Resolves #135

Description

  • Added an endpoint for unlinking contacts from an entity

Related PRs

CodeForBaltimore/Healthcare-Rollcall#128

Todos

  • Similar endpoint for contacts route
  • Swagger

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #140 into master will decrease coverage by 2.07%.
The diff coverage is 8.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   64.35%   62.28%   -2.08%     
==========================================
  Files          16       16              
  Lines         505      525      +20     
==========================================
+ Hits          325      327       +2     
- Misses        180      198      +18     
Impacted Files Coverage Δ
src/routes/entity.js 29.06% <8.33%> (-2.51%) ⬇️
src/routes/contact.js 30.76% <9.09%> (-3.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f6702...ca61876. Read the comment docs.

Copy link
Member

@stoopidJSON stoopidJSON left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under normal circumstances the test coverage would need to go up for approval, but otherwise looks good!

@stoopidJSON stoopidJSON merged commit 5ca2d0d into master May 7, 2020
@stoopidJSON stoopidJSON deleted the c-w-allen/issue-135 branch May 7, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unlink entity-contact

3 participants