Skip to content

Conversation

@blakenan-bellese
Copy link
Contributor

Description

Improved postman collection in a few ways as described in Issue 136 ACs:

  • Use dynamic logic/shared token across collection so it can be used with serve that require login
  • Add environment definitions and leverage common baseUrl to make config easier for deployments other than localhost:3000
  • Correct error in DEL Entity (currently uses contact end point)
  • Add new entity-contact linking endpoints (see Swagger after merge)

Also added rudimentary test to each call to verify return of 200, allows collection to be run as regression test. Also, externalized URL and login in environment variables seeded from separate postman env definition.

resolves #136

Related PRs

None

Todos

  • Tests
  • Documentation

Deploy Notes

None

Steps to Test or Reproduce

None

Impacted Areas in Application

n/a

Postman Environment Variable for typical local environment
Used env variables to make URL and initial user login more flexible and link responses of some calls to requests of subsequent calls.  Created postman local env definition to compliment
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   62.28%   62.28%           
=======================================
  Files          16       16           
  Lines         525      525           
=======================================
  Hits          327      327           
  Misses        198      198           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14df75...7b28aa3. Read the comment docs.

@stoopidJSON
Copy link
Member

@allcontributors add @blakenan-bellese for testing

@allcontributors
Copy link
Contributor

@revjtanton

I've put up a pull request to add @blakenan-bellese! 🎉

@blakenan-bellese
Copy link
Contributor Author

@revjtanton This has been hanging out for a while. Can we get this merged? Thanks.

@stoopidJSON stoopidJSON merged commit a07fb1a into master May 21, 2020
@stoopidJSON stoopidJSON deleted the blakenan-bellese/Issue136 branch May 21, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Housekeeping of postman collection

3 participants