Revjtanton/hotfix sequelize ssl #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
- Coverage 63.23% 61.91% -1.33%
==========================================
Files 16 16
Lines 525 533 +8
==========================================
- Hits 332 330 -2
- Misses 193 203 +10
Continue to review full report at Codecov.
|
c-w-allen
reviewed
May 12, 2020
| } | ||
| const a = await SequelizeAdapter.newAdapter( | ||
| dbUrl, | ||
| dbUrl(), |
Contributor
There was a problem hiding this comment.
Is this calling a function now? Where is it defined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix an issue iwth SSL and Sequelize. Additionally, it adds a fix for the email reset to go to the correct domain.
Todos