Issue 216 #220
Issue 216 #220
Conversation
| "path": "/entity", | ||
| "method": "GET" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Since you're wildcarding, do you need the rule above this one?
There was a problem hiding this comment.
My understanding is that Casbin is touchy. It is very literal, so anything leading up to a wildcard isn't allowed because of the wildcard, but I'll test this.
| entity.address = (address) ? address : entity.address | ||
| entity.phone = (phone) ? phone : entity.phone | ||
| entity.email = (email) ? email : entity.email | ||
| entity.email = (email) ? email : entity.email |
There was a problem hiding this comment.
Did you intend to tab these back?
There was a problem hiding this comment.
Didn't realize I did. Probably linter.
| "responses" : { | ||
| "200" : { | ||
| "201" : { | ||
| "description" : "contact created" |
There was a problem hiding this comment.
unrelated: can we capitalize C in contact?
There was a problem hiding this comment.
Actually I'm not sure what to put here. The actual message is ${contact.id} created. For now I'm going to leave as is, but we'll circle back on all responses like this to figure out what we want to say there.
|
Not sure what's up with Codecov. There is a ticket #221 to look into this. Merging without Codecov passing. |
This allows attribute saving on entities. Also fixes JWT's only identifying
users as users and not admin/user, etc.
resolves #216
resolves #217
Todos
Impacted Areas in Application
List general components of the application that this PR will affect: