Skip to content

Conversation

@stoopidJSON
Copy link
Member

This will add RDS SSL capabilities and validation using pem. Additionally
this will add validations to emails for contacts created through the API directly.

Todos

  • Tests
  • Documentation

Deploy Notes

Trying to use production as the environment type will cause errors unless with RDS.

Impacted Areas in Application

List general components of the application that this PR will affect:

  • database connections
  • validations

This will add RDS SSL capabilities and validation using pem. Additionally
this will add validations to emails for contacts created through the API directly.
@stoopidJSON stoopidJSON requested review from a team and williamdanielani April 1, 2020 02:48
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #88 into master will decrease coverage by 0.01%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   67.36%   67.34%   -0.02%     
==========================================
  Files          12       12              
  Lines         334      343       +9     
==========================================
+ Hits          225      231       +6     
- Misses        109      112       +3     
Impacted Files Coverage Δ
src/utils/index.js 95.65% <ø> (+8.15%) ⬆️
src/models/index.js 78.57% <42.85%> (-11.91%) ⬇️
src/routes/contact.js 45.83% <50.00%> (+0.18%) ⬆️
src/routes/user.js 65.62% <75.00%> (+0.54%) ⬆️
src/routes/entity.js 37.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cbf201...6acd386. Read the comment docs.

@stoopidJSON stoopidJSON merged commit cf5702b into master Apr 1, 2020
@stoopidJSON stoopidJSON deleted the revjtanton/v1-finalize branch April 1, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants