This repository was archived by the owner on Jun 19, 2020. It is now read-only.
Basic Dashboard and MetaTags #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm inclined to not spend a ton of time making sure every UX detail is perfect, there's a lot that could change and I'd rather not sink all that time into something that may not end up in the final tool. Everything else looks good, maybe we merge as-is and open an issue to address it as needed. |
jbixon13
approved these changes
Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
List related PRs against other branches:
Related Issues
List related Issues:
| #2 |
| #4 |
Todos
Review meta tags for edits or additions.
Review and/or consolidate public folder now containing favicons.
Add or fix css for button links in CardCategory.js to push wrapper to bottom of <Card.Body>.
Tried solution explained here https://stackoverflow.com/questions/48406628/bootstrap-align-button-to-the-bottom-of-card but it did not work.
Deploy Notes
Added one more small dependency , react-router-rootstrap.
Steps to Test or Reproduce
If this is the first time cloning the repository:
To install added dependency:
To run local development build:
Impacted Areas in Application
-Home page now acts as basic dashboard component with BootStrap Card UI.
-Navigation to page categories added via links on Home.
Navigation to page subcategories added via links within category pages.