Bump Node version in travis and fix integration test #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praneetap
approved these changes
Mar 25, 2020
Contributor
Author
|
🎉 This PR is included in version 3.3.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.travis.ymlto the LTS versions support in AWS Lambda (10 and 12)The integration test failure is caused by a change in Node's behavior after version 10. Requests with a body and
content-lengthheader value < 0 used to throw an exception, caught by our library and handled by returning a 502 error. In the latest releases of Node these requests don't fail anymore and instead reach Express that returns a 400.I have disabled the integration test since the model of the 502 response is still checked by our unit tests. We will need to find a different way to cause Node/Express to throw an exception to validate the behavior in integration tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.