Revert the major breaking change in 4.3.10 #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert to the old behavior of just routing on the proxy part. 4.3.10 is a major breaking change for existing users depending on the current behavior. This will fix #454
Contributor
|
Sorry about that, I thought we had tests that covered this. I'll look into fixing the other issue and adding tests. Thanks! |
|
🎉 This PR is included in version 4.3.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
OneDev0411
added a commit
to OneDev0411/serverless-express
that referenced
this pull request
Mar 16, 2023
## [4.3.11](CodeGenieApp/serverless-express@v4.3.10...v4.3.11) (2021-08-31) ### Bug Fixes * revert [#441](CodeGenieApp/serverless-express#441) ([#455](CodeGenieApp/serverless-express#455)) ([87aa26f](CodeGenieApp/serverless-express@87aa26f)), closes [#454](CodeGenieApp/serverless-express#454)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Revert to the old behavior of just routing on the proxy part.
4.3.10 is a major breaking change for existing users depending on the current behavior.
@selvendranayyaswamy
@selvendran.ayyaswamy
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.