fix: bug when empty event headers (#462) #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to in several express.js libraries treats req.headers as NonNullable Object,
when event headers is null causing bugs.
When incoming headers from API Gateway is null, it should transform to {}.
Fix CodeGenieApp#462
|
🎉 This PR is included in version 4.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
OneDev0411
added a commit
to OneDev0411/serverless-express
that referenced
this pull request
Mar 16, 2023
## [4.5.1](CodeGenieApp/serverless-express@v4.5.0...v4.5.1) (2021-10-13) ### Bug Fixes * bug when empty event headers ([#462](CodeGenieApp/serverless-express#462)) ([#463](CodeGenieApp/serverless-express#463)) ([2b66164](CodeGenieApp/serverless-express@2b66164))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to in several express.js libraries treats req.headers as NonNullable Object,
when event headers is null causing bugs.
When incoming headers from API Gateway is null, it should transform to {}.
Fix #462, #417
Issue #, if available: #462, #417
Description of changes: check
event.headersis nullChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.