fix: assertion failure when fuzzing proto strings #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonresch
force-pushed
the
CIF-1814-fix-possible-negative-size-increase
branch
from
13f0274 to
935705d
Compare
When parsing protobuf messages from libfuzzer bytes in the protobuf mutator we don't enforce length limits. This could lead to maxSizeIncrease < 0 situations if the e.g. a String read by the protobuf mutator exceeds the size limit. To guard against similar cases we now enforce the size constraints for the byte array that is being mutated before performing the mutation.
simonresch
force-pushed
the
CIF-1814-fix-possible-negative-size-increase
branch
from
935705d to
00f03d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing protobuf messages from libfuzzer bytes in the protobuf mutator we don't enforce length limits. This could lead to maxSizeIncrease < 0 situations if the e.g. a String read by the protobuf mutator exceeds the size limit.
To guard against similar cases we now enforce the size constraints for the byte array that is being mutated before performing the mutation.