Skip to content

Conversation

@simonresch
Copy link
Contributor

@simonresch simonresch commented Oct 30, 2025

Hook to guide inputs to MVEL interpreter towards performing OS commands which are detected by the OS command injection sanitizer.

@simonresch simonresch changed the base branch from main to CIF-1848-jexl-injection October 30, 2025 09:50
@florianGla florianGla force-pushed the CIF-1848-jexl-injection branch 2 times, most recently from f47d1ba to 5a3f385 Compare October 30, 2025 14:21
@simonresch simonresch force-pushed the CIF-1847-mvel-guidance-hook branch from 70ace1b to e33dc9c Compare October 31, 2025 08:06
@florianGla florianGla force-pushed the CIF-1848-jexl-injection branch 2 times, most recently from 3123ca0 to 4404cd0 Compare October 31, 2025 09:02
Base automatically changed from CIF-1848-jexl-injection to main October 31, 2025 09:39
Hook to guide inputs to MVEL interpreter towards performing OS commands
which are detected by the OS command injection sanitizer.
@simonresch simonresch force-pushed the CIF-1847-mvel-guidance-hook branch from e33dc9c to 083058b Compare October 31, 2025 10:26
@simonresch simonresch marked this pull request as ready for review October 31, 2025 10:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for detecting MVEL expression language injection vulnerabilities by implementing a guidance hook that directs fuzzing inputs toward OS command execution patterns that trigger the OS command injection sanitizer.

Key changes:

  • Added MVEL guidance hook to detect expression language injection via Runtime.exec() calls
  • Implemented fuzz test for MVEL expression evaluation
  • Integrated MVEL library (version 2.5.2.Final) as a test dependency

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ExpressionLanguageInjection.kt Added MVEL guidance hook with attack pattern and method hooks for various MVEL eval/compile methods
ExpressionLanguageInjection.java Added fuzz test method for MVEL expression evaluation
BUILD.bazel (test) Added MVEL dependency and fuzzMVELExpression to test methods list, expanded allowed findings
BUILD.bazel (sanitizers) Added MVEL dependency for sanitizer tests
MODULE.bazel Added MVEL library to test Maven artifacts
maven_install.json Added MVEL library metadata and updated artifact hashes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@florianGla florianGla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simonresch simonresch merged commit f104955 into main Oct 31, 2025
9 checks passed
@simonresch simonresch deleted the CIF-1847-mvel-guidance-hook branch October 31, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants