feat(identity): simplify Uuid class

Author: Bartosz Pasiński

packages/identity/README.md

@@ -41,8 +41,8 @@ Creating value objects:
 ```ts
 import { Uuid } from '@code-net/identity';
 
-class UserId extends Uuid.for('User') {}
-class ProductId extends Uuid.for('Product') {}
+class UserId extends Uuid<'User'> {}
+class ProductId extends Uuid<'Product'> {}
 
 let userId = new UserId();
 let productId = new ProductId();

packages/identity/src/uuid.ts

@@ -15,7 +15,7 @@ export class Uuid<T = unknown> {
   constructor(private readonly id: string = uuid.v4()) {
     if (!uuid.isValid(id)) {
       throw new InvalidValue(
-        `${this.__brand} ID is not valid UUID, given: "${id}"`
+        `${this.constructor.name} is not valid UUID, given: "${id}"`
       );
     }
   }
@@ -43,17 +43,4 @@ export class Uuid<T = unknown> {
   valueOf() {
     return this.id;
   }
-
-  static for<T>(): new (id?: string) => Uuid<T> {
-    return class UuidFor extends Uuid<T> {
-      constructor(id: string = uuid.v4()) {
-        super(id);
-        if (!uuid.isValid(id)) {
-          throw new InvalidValue(
-            `${this.__brand} is not valid UUID, given: "${id}"`
-          );
-        }
-      }
-    };
-  }
 }

packages/identity/test/identity.spec.ts

@@ -1,8 +1,8 @@
 import { Uuid } from '../src';
 
 it('should fail typechecking', () => {
-  class UserId extends Uuid.for<'User'>() {}
-  class ProductId extends Uuid.for<'Product'>() {}
+  class UserId extends Uuid<'User'> {}
+  class ProductId extends Uuid<'Product'> {}
 
   let userId = new UserId();
   const productId = new ProductId();
@@ -11,3 +11,11 @@ it('should fail typechecking', () => {
   userId = productId;
   expect(userId).toBeDefined();
 });
+
+it('will throw InvalidValue for invalid UUID', () => {
+  class MyId extends Uuid<'My'> {}
+
+  expect(() => {
+    new MyId('invalid-uuid');
+  }).toThrow(`MyId is not valid UUID, given: "invalid-uuid"`);
+});