Notifications cleanups #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
podviaznikov
commented
Jan 15, 2015
podviaznikov
commented
- double escape branch name and commit message
- skip git hub push that don't have commits. E.x. just tag was pushed
- add tests for branch name escaping
- add process.env.ENABLE_NEW_BRANCH_BUILDS_ON_GIT_PUSH to enable/disable new branch builds
Member
Author
|
@tjmehta this has It also has few minor changes (fix a bug from rollbar earlier in the morning) and more unit tests. |
Contributor
|
👍 thanks anton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.