User vault rollbar trap #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 25, 2017 16:22
anandkumarpatel
requested changes
May 25, 2017
| log::info "Setting Poppa ID" | ||
|
|
||
| # Generate the org-tag fetching script | ||
| rollbar::fatal_trap \ |
Contributor
There was a problem hiding this comment.
why is this a warning? if this fails we need the server to halt right
Contributor
Author
There was a problem hiding this comment.
if its a warning, won't that mean it never halts? we want to keep retrying in this case
Contributor
There was a problem hiding this comment.
your right, I thought this was after the loop
anandkumarpatel
approved these changes
May 26, 2017
| log::info "Setting Poppa ID" | ||
|
|
||
| # Generate the org-tag fetching script | ||
| rollbar::fatal_trap \ |
Contributor
There was a problem hiding this comment.
your right, I thought this was after the loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.