Skip to content

Commit 5e9ad07

Browse files
committed
Use .forRoot for NGRX + update common-data lib file structure
1 parent 76deb1c commit 5e9ad07

27 files changed

+81
-61
lines changed

apps/dashboard/src/app/app.module.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,6 @@ import { StoreDevtoolsModule } from '@ngrx/store-devtools';
4444
AppMaterialModule,
4545
CommonDataModule,
4646
TotalsViewModule,
47-
NxModule.forRoot(),
48-
StoreModule.forRoot({}),
49-
EffectsModule.forRoot([]),
50-
StoreDevtoolsModule.instrument({
51-
maxAge: 5
52-
}),
5347
],
5448
bootstrap: [AppComponent]
5549
})

libs/common-data/src/index.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
export { CommonDataModule } from './lib/common-data.module';
22

3-
export { Item } from './lib/items/item.model';
4-
export { ItemsService } from './lib/items/items.service';
3+
export { Item } from './lib/core/items/item.model';
4+
export { ItemsService } from './lib/core/items/items.service';
55

6-
export { Widget } from './lib/widgets/widget.model';
7-
export { WidgetsService } from './lib/widgets/widgets.service';
6+
export { Widget } from './lib/core/widgets/widget.model';
7+
export { WidgetsService } from './lib/core/widgets/widgets.service';
88

9-
export { ItemsFacade } from './lib/state/items.facade';
10-
export { WidgetsFacade } from './lib/state/widgets.facade';
9+
export { ItemsFacade } from './lib/state/items/items.facade';
10+
export { WidgetsFacade } from './lib/state/widgets/widgets.facade';

libs/common-data/src/lib/api-config.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

libs/common-data/src/lib/common-data.module.ts

Lines changed: 5 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,17 @@
11
import { CommonModule } from '@angular/common';
22
import { HttpClientModule } from '@angular/common/http';
33
import { NgModule } from '@angular/core';
4-
import { EffectsModule } from '@ngrx/effects';
5-
import { StoreModule } from '@ngrx/store';
6-
import { ItemsService } from './items/items.service';
7-
import { ItemsEffects } from './state/items.effects';
8-
import { ItemsFacade } from './state/items.facade';
9-
import { initialState as itemsInitialState, itemsReducer } from './state/items.reducer';
10-
import { WidgetsEffects } from './state/widgets.effects';
11-
import { initialState as widgetsInitialState, widgetsReducer } from './state/widgets.reducer';
12-
import { WidgetsService } from './widgets/widgets.service';
4+
5+
import { StateModule } from './state/state.module';
136

147
@NgModule({
158
imports: [
169
CommonModule,
1710
HttpClientModule,
18-
StoreModule.forFeature('items', itemsReducer, { initialState: itemsInitialState }),
19-
StoreModule.forFeature('widgets', widgetsReducer, { initialState: widgetsInitialState}),
20-
EffectsModule.forFeature([ItemsEffects, WidgetsEffects]),
21-
],
22-
providers: [
23-
ItemsService,
24-
WidgetsService,
25-
ItemsEffects,
26-
ItemsFacade,
27-
WidgetsEffects
11+
StateModule
2812
],
29-
exports: [
30-
StoreModule,
31-
EffectsModule
32-
]
13+
providers: [],
14+
exports: []
3315
})
3416

3517
export class CommonDataModule {
File renamed without changes.

libs/common-data/src/lib/items/items.service.spec.ts renamed to libs/common-data/src/lib/core/items/items.service.spec.ts

File renamed without changes.

libs/common-data/src/lib/items/items.service.ts renamed to libs/common-data/src/lib/core/items/items.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { HttpClient, HttpHeaders, HttpParams } from '@angular/common/http';
55
const BASE_URL = 'http://localhost:3000/items/';
66
const HEADER = {headers: new HttpHeaders({'Content-Type': 'application/json'})};
77

8-
@Injectable()
8+
@Injectable({providedIn: 'root'})
99
export class ItemsService {
1010
constructor(private http: HttpClient) {
1111
}
File renamed without changes.

libs/common-data/src/lib/widgets/widgets.service.spec.ts renamed to libs/common-data/src/lib/core/widgets/widgets.service.spec.ts

File renamed without changes.

libs/common-data/src/lib/widgets/widgets.service.ts renamed to libs/common-data/src/lib/core/widgets/widgets.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { HttpClient, HttpHeaders, HttpParams } from '@angular/common/http';
55
const BASE_URL = 'http://localhost:3000/widgets/';
66
const HEADER = {headers: new HttpHeaders({'Content-Type': 'application/json'})};
77

8-
@Injectable()
8+
@Injectable({providedIn: 'root'})
99
export class WidgetsService {
1010
constructor(private http: HttpClient) {
1111
}

0 commit comments

Comments
 (0)