[Week8] Make API Docs and Docker image #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
상품 서비스의 public 메서드들에 javadoc형식으로 주석을 작성했습니다.
상품 컨트롤러의 public 메소드들에 javadoc 형식으로 주석을 작성했습니다.
johngrib
reviewed
Mar 17, 2021
app/src/main/java/com/codesoom/assignment/application/ProductService.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/codesoom/assignment/application/ProductService.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/codesoom/assignment/application/ProductService.java
Outdated
Show resolved
Hide resolved
johngrib
reviewed
Mar 17, 2021
app/src/main/java/com/codesoom/assignment/controllers/ProductController.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/codesoom/assignment/controllers/ProductController.java
Show resolved
Hide resolved
johngrib
reviewed
Mar 17, 2021
Collaborator
johngrib
left a comment
johngrib
left a comment
There was a problem hiding this comment.
오래간만입니다. 이번주도 열심히 해 봅시다!
Author
이번주는 레고나 프라모델을 내 마음대로 쪼물딱거리는 느낌으로 |
명확하고 간단한 주석이 되도록 수정하고 필요없는 공백을 삭제했습니다.
회원 서비스의 public 메소드들의 역할을 javadoc으로 작성하였습니다
Merged
johngrib
reviewed
Mar 19, 2021
Collaborator
johngrib
left a comment
johngrib
left a comment
There was a problem hiding this comment.
주석도 좋지만 이제 Docker 작업을 하셔야 하지 않을까요?!
Author
도전해보겠습니다! |
application.yaml과 build.gradle에 mariadb를 적용했습니다
johngrib
reviewed
Mar 20, 2021
| profiles: mariadb | ||
| url: jdbc:mariadb://mariadb:3306/test | ||
| username: root | ||
| password: root1234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.