LONDON | ITP MAY-2025 | Hibo Sharif | Form control | Week2 #438
Conversation
The name The client Email The choice of three colours The choices of Tshirt sizes modified: Form-Controls/index.html
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hibosharif202504
changed the title
hibosharif202504
added
the
Needs Review
hibosharif202504
requested review from
jenny-alexander,
SallyMcGrath and
AdnaanA
and removed request for
SallyMcGrath
hibosharif202504
changed the title
|
A well-prepared PR makes it easier for reviewers to approve it with minimal back-and-forth. And as a practice to get better at using AI tools, try running your code by ChatGPT. You can ask ChatGPT Then take a look at the suggestions it gives you, and pick out the ones that actually make sense for your project. It's a great way to learn and improve your work. Once you've finished making changes, please leave a comment on this PR so I’ll get notified. Thanks! |
cjyuan
added
Reviewed
…on the HTML using the W3C Markup validation service. - I indented the file to make it easier to read. - I have used the AI tool to modify the code.
|
Hi @cjyuan , Thank you for the review.. I have followed the guide published on the Canvas and checked my work using the W3C HTML validation tool. I have also checked the code using the AI tool and made some adjustment to the code. Many thanks. |
hibosharif202504
added
the
Needs Review
Form-Controls/index.html
Outdated
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <div style="margin-bottom: 20px"> |
There was a problem hiding this comment.
The spec does says, "No CSS" (including inline CSS).
Can you update your implementation accordingly? You may want to check your lighthouse score after you remove the CSS.
There was a problem hiding this comment.
Hi @cjyuan ,
I have removed the CSS codes form the file and I have used lighthouse to check the score of the webpage. Bellow is a link to the score page:
Form-Controls/index.html
Outdated
| name="name" | ||
| id="name" | ||
| required | ||
| pattern="[A-Za-z\s]{2,50}" |
There was a problem hiding this comment.
With this pattern, a user can enter a name containing only space characters. Can you enforce a stricter rule to deny any name containing only space characters?
There was a problem hiding this comment.
Hi @cjyuan
I have updated the code to enforce the rule of no name only containing space characters.
cjyuan
removed
the
Needs Review
hibosharif202504
added
the
Needs Review
|
Changes look good. Well done! |
cjyuan
added
Complete
Learners, PR Template
Self checklist
Changelist
I have made number of changes to the file to add:
1- The customer's name.
2- The customer's email. The customer email must be valid.
3-Add three choices of t-shirt colour.
4- Give options for size does that the customer want. It must be the following 6 options : XS, S, M, L, XL, XXL
Questions
Please would you review my changes.