London | May-2025 | Mohammadreza Babaei | Wireframe

[Moreza-event]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	14bc9a6
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-onboarding-module/deploys/682492b60046b00008d7fa94
😎 Deploy Preview	https://deploy-preview-472--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 94 (🔴 down 6 from production) Accessibility: 92 (🔴 down 8 from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[cjyuan]

Comment deleted because they were meant for Form-Controls/index.html

[cjyuan]

A PR branch should include only the changes relevant to the specific task or feature it addresses.
You can see all the modified files in the current branch in the "Files changed" tab of this PR:
https://github.com/CodeYourFuture/Module-Onboarding/pull/472/files

Are the modified file in the "Form-Controls" folder and the modified index.html in the top level folder related to your wireframe implementation? If not, you should revert the changes made in those files in order to make this branch clean.

To revert the changes made to certain files, you can replace them with the versions from your main branch.
(The files in the main branch remain unmodified since you forked them from CYF.)
Here’s how to do it:
1. Download the original versions of the files from your main branch on GitHub.
2. On your computer (in VSCode), switch to the branch where you want to revert the changes. (Mo-reza_Articles)
3. Replace the modified files with the downloaded versions from the main branch.
4. Commit the changes and push the commit to GitHub.

[cjyuan]

Code is error free. Thanks.

1. One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means or look up the meaning of "viewport").

2. When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you align the height of the images in the 2nd and 3rd articles?

[cjyuan]

Line 37 can be better formatted as:

          A branch in Git is a separate line of development within a repository.
          It allows developers to work on different features or fixes
          simultaneously without affecting the main codebase. Branches are often
          used to isolate changes, making it easier to manage and review code
          before merging it back into the main branch. This helps maintain a
          clean and organized project history.

To understand why, you can ask ChatGPT these questions:

• How HTML treat mutliple whitespace characters in text?
• What's the advantage of not writing a long paragraph of text in a single line in HTML?

VSCode's "Format Document" feature can help us format our code for better readability and consistency, including breaking a long line of text into shorter lines of text.
To use the feature, right-click inside the code editor and select the option.
Please note that if there are syntax errors in the code, the "Prettier" extension may not format HTML code properly.