London | ITP May25 | Mohammadreza Babaei | Form Control #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cjyuan
reviewed
Jun 6, 2025
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
Can you improve the Lighthouse Accessibility score of your page to 100?
-
To follow best practices, can you update your PR description by carrying out the following actions?
- Check the items in the Self-Checklist to confirm your pull request meets the guidelines
- Provide a brief description (under the "Changelist" section) summarizing the purpose of the PR and the changes you’ve made
| this will also help you fill in your PR message later--> | ||
|
|
||
| <label for="name">Full name:</label> | ||
| <input type="text" id:"name" name"name" type="text" required minlength="2" /> |
There was a problem hiding this comment.
-
Can you improve the indentation of the code?
-
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the
patternattribute to disallow any name that contains only space characters?
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.