Manchester | 25-ITP-SEP | Fithi Teklom | Sprint 2 | Form controls #843
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Fithi-Teklom
added
📅 Sprint 2
Form-Controls/index.html
Outdated
| this will also help you fill in your PR message later--> | ||
| <!-- Customer name --> | ||
| <label for="name">Full Name:</label> | ||
| <input id="name" type="text" name="name" pattern="[A-Za-z\s]{2,}" required /> |
There was a problem hiding this comment.
@Fithi-Teklom Could you answer this comment please?
This is an advanced attribute & want to make sure you understand it / understand how you came up with it
There was a problem hiding this comment.
Yes I do understand it. I was using AI tools to help with my projects. It showed me that attribute and I have asked chatgpt to clarify and break it down as well. So yes, I do understand what it means.
There was a problem hiding this comment.
Is there another way to achieve this?
If I have a double barrelled name (e.g. Beyoncé Knowles-Carter), this pattern won't let me submit the form
Form-Controls/index.html
Outdated
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Do we need this big space here?
Programmers are very particular about how code is formatted - the rest of the file is perfect 👍
There was a problem hiding this comment.
It was a mistake I have fixed it.
Form-Controls/index.html
Outdated
| </selct> | ||
|
|
||
| <!-- Submit button --> | ||
| <input type="submit" value="submit" |
There was a problem hiding this comment.
This button doesn't appear to work when I press it - do you know why this might be?
There was a problem hiding this comment.
I did not close the tag with closing tag. So that is why it wasn't working.
There was a problem hiding this comment.
I also had to use the button tag.
Form-Controls/index.html
Outdated
| <selct id="size" name="size" required> | ||
| <option>--Select a size--</option> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XLL">XLL</option> | ||
| </selct> |
There was a problem hiding this comment.
This input isn't being displayed correctly:
There was a problem hiding this comment.
Spelling error happened (selct) instead of select.
Form-Controls/index.html
Outdated
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> |
There was a problem hiding this comment.
Could you check this HTML with a HTML validator and solve any issues?
You can copy & paste your HTML under Validate by direct input
There was a problem hiding this comment.
Hi Cameron
I have fixed the problems and made a progress, so I have removed the complete label and labeled it as needs to review. So I hope you review it again and comment or label it, so that i can start enrolling as a trainee.
Thank you!
CameronDowner
added
Complete
Fithi-Teklom
added
Needs Review
| <!-- T-shirt size--> | ||
| <div> | ||
| <label for="size">Choose T-shirt Size</label> | ||
| <select id="size" name="size" required> |
There was a problem hiding this comment.
I can submit without selecting a size - why do you think this might be?
CameronDowner
added
Reviewed
Fithi-Teklom
added
Needs Review
CameronDowner
added
Review in progress
CameronDowner
added
Complete
Self checklist
Added T-shirt form control with size and color options. The latest is the proper one.