Skip to content

Conversation

zilinskyte
Copy link

@zilinskyte zilinskyte commented Sep 23, 2025

Georgina Rogers PR

Self checklist

  • [ x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [x ] My changes follow the style guide

Changelist

Pull request demonstrates branch has been created off main.

Questions

No questions

Copy link

netlify bot commented Sep 23, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit d05cd01
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68d284fba9b4f6000887d9d4
😎 Deploy Preview https://deploy-preview-846--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 95 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@zilinskyte zilinskyte added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 23, 2025
@sambabib sambabib added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 29, 2025
<h2>Understanding README Files</h2>
<p>A README file is a crucial part of any project, providing an overview, setup instructions, and important documentation for developers and users.
It tells others why your project is useful and how it can be used within your expectations and guidelines.</p>
<a href="https://www.example.com/readme-guide" role="button" target="_blank" rel="noopener">Learn more about README files</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for your tags, there are ways to ensure they do not link to a page that does not exist., if you do not have a real webpage to link to you should look up preventing default behavior in anchor tags. this is a good place to start: https://stackoverflow.com/questions/265478/preventdefault-on-an-a-tag

this is beyond the scope of this assignment as you have not been asked to but it is something to note for future assignments. instead of navigating to a dummy link like www.example.com/*, you can use one of the suggestions in the link above.


article {
flex: 1;
margin: 0 10px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good css and good solution. well done!

@sambabib sambabib added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants