Skip to content

Conversation

CatchingKiyoko
Copy link

@CatchingKiyoko CatchingKiyoko commented Sep 27, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  1. added 3 sections one for each of the topics each with a link to external sites for additional explanation.
  2. updated css to add underlines to the titles.
  3. also updated css to align the 3rd section of code so no excessive margins/borders affect the page spacing.
  4. refactored the code so its easier to read.

Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

Copy link

netlify bot commented Sep 27, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 86ae821
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68d7c0205953810008dc2ee8
😎 Deploy Preview https://deploy-preview-864--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@CatchingKiyoko CatchingKiyoko added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Sep 27, 2025
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

2 similar comments
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

@CatchingKiyoko CatchingKiyoko changed the title Sheffield | 25-ITP-SEP | Declan Williams | Onboarding | Wireframe Sheffield | 25-ITP-SEP | Declan Williams | Sprint 1 | Wireframe Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module-Onboarding The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant