Skip to content

Conversation

Mahtem
Copy link

@Mahtem Mahtem commented Sep 27, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Wrote HTML codes to take client info via forms the information to be collected are, name, email, color and size.
The page validates, names (minimum 2 characters), email (valid email), make sure at least one color and size are selected.

Questions

How can we more efficiently write the code?

Copy link

netlify bot commented Sep 27, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit b547b68
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68d9ad965757060008ffcbdf
😎 Deploy Preview https://deploy-preview-875--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Mahtem Mahtem added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 27, 2025
Copy link

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Mahtem Mahtem added the 📅 Sprint 2 Assigned during Sprint 2 of this module label Sep 27, 2025
Copy link

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
Copy link

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Mahtem Mahtem changed the title Manchester|25-ITP-Sep |Mahtem Mengstu|Sprint 2|Forms Manchester | 25-ITP-Sep | Mahtem Mengstu | Sprint 2 | Forms Sep 27, 2025
Copy link

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
Copy link

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Mahtem Mahtem changed the title Manchester | 25-ITP-Sep | Mahtem Mengstu | Sprint 2 | Forms Manchester | 25-ITP-Sep | Mahtem Mengstu | Sprint 2 | Forms Controls Sep 27, 2025
@Mahtem Mahtem changed the title Manchester | 25-ITP-Sep | Mahtem Mengstu | Sprint 2 | Forms Controls Manchester | 25-ITP-Sep | Mahtem Mengstu | Sprint 2 | Form Controls Sep 27, 2025
Copy link

@CameronDowner CameronDowner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good - only minor comments 🙂

<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>

<h2>By COTTON SOLUTIONS, Ltd</h2>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be your name

try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
<form>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting is slightly off here - each new element should be indented

You can do this within VS code by using Format document - https://code.visualstudio.com/docs/editing/codebasics#_formatting

@CameronDowner CameronDowner added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants