-
-
Notifications
You must be signed in to change notification settings - Fork 307
Manchester | 25-ITP-Sep | Mahtem Mengstu | Sprint 2 | Form Controls #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good - only minor comments 🙂
Form-Controls/index.html
Outdated
<!-- change to your name--> | ||
<h2>By HOMEWORK SOLUTION</h2> | ||
|
||
<h2>By COTTON SOLUTIONS, Ltd</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be your name
Form-Controls/index.html
Outdated
try writing out the requirements first as comments | ||
this will also help you fill in your PR message later--> | ||
</form> | ||
<form> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting is slightly off here - each new element should be indented
You can do this within VS code by using Format document
- https://code.visualstudio.com/docs/editing/codebasics#_formatting
Learners, PR Template
Self checklist
Changelist
Wrote HTML codes to take client info via forms the information to be collected are, name, email, color and size.
The page validates, names (minimum 2 characters), email (valid email), make sure at least one color and size are selected.
Questions
How can we more efficiently write the code?