Add sourcemap #345
Merged
Add sourcemap #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyighsu
requested review from
brandonkachen,
charleslien and
jahooma
as code owners
jahooma
reviewed
Oct 18, 2025
jahooma
reviewed
Oct 18, 2025
sdk/scripts/build.ts
Outdated
| target: 'node', | ||
| format: 'cjs', | ||
| minify: false, | ||
| sourcemap: 'external', |
Contributor
There was a problem hiding this comment.
I wonder if the two source maps conflict? Maybe we should just generate one, IDK
Contributor
Author
There was a problem hiding this comment.
I believe you need both since consumers will be either/or and not both
Contributor
|
Thanks Danny! |
jahooma
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ease of debugging for SDK consumers.
Tested on local w/ the fork to confirm source maps appear and are viewable.