Entry html s element #1234

Buono-Marco · 2022-11-11T10:43:48Z

Description

Added a new entry about the HTML element <s>

Type of Change

Adding a new entry

Checklist

All writings are my own.
My entry follows the Codecademy Docs style guide.
My changes generate no new warnings.
I have performed a self-review of my own writing and code.
I have checked my entry and corrected any misspellings.
I have made corresponding changes to the documentation if needed.
I have confirmed my changes are not being pushed from my forked main branch.
I have confirmed that I'm pushing from a new branch named after the changes I'm making.
Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

CLAassistant · 2022-11-11T10:46:04Z

All committers have signed the CLA.

SSwiniarski

@Buono-Marco, I did a first review and left a couple of comments.

SSwiniarski · 2022-11-12T14:09:29Z

content/html/concepts/elements/terms/s/s.md

+  - 'paths/front-end-engineer-career-path'
+---
+
+The **`<s>`** element is used to highlight no more pertinent, accurate, or wrong text. Browsers render it showing strikethrough text. Its behavior equals the <del> element but is semantically different. This last is usually used to show document changes.


Suggested change

The **`<s>`** element is used to highlight no more pertinent, accurate, or wrong text. Browsers render it showing strikethrough text. Its behavior equals the <del> element but is semantically different. This last is usually used to show document changes.

The **`<s>`** element is used to highlight no longer pertinent, inaccurate, or wrong text. Browsers render it showing strikethrough text. Its behavior equals the <del> element but is semantically different, <del> is usually used to show document changes.

SSwiniarski · 2022-11-12T14:10:15Z

content/html/concepts/elements/terms/s/s.md

+
+```html
+<s>
+  <!-- Text no more pertinent, accurate, or wrong to here -->


Suggested change

SSwiniarski · 2022-11-12T14:16:58Z

@Buono-Marco, are you going to do another PR on the <del> tag?

…/docs into entry-html-s-element

Buono-Marco · 2022-11-14T18:16:47Z

@Buono-Marco, are you going to do another PR on the <del> tag?

Yes

SSwiniarski

@Buono-Marco Looks good for a second review.

Dusch4593

@Buono-Marco Finished with my review and left some comments/suggestions 😄

Dusch4593 · 2022-11-15T17:03:10Z

content/html/concepts/elements/terms/s/s.md

+
+## Syntax
+
+```html


Suggested change

```html

```pseudo

Dusch4593 · 2022-11-15T17:11:07Z

content/html/concepts/elements/terms/s/s.md

+</s>
+```
+
+The **`<s>`** element should only contain text content or other elements meant for text content.


Suggested change

The **`<s>`** element should only contain text content or other elements meant for text content.

The `<s>` element should only contain text content or other elements meant for text content.

> **Note:** The `<s>` element is semantically different from the `<del>` element because the former is just an edit while the latter conveys an actual update in a document.

content/html/concepts/elements/terms/s/s.md

Dusch4593 · 2022-11-15T17:12:13Z

content/html/concepts/elements/terms/s/s.md

+  - 'paths/front-end-engineer-career-path'
+---
+
+The **`<s>`** element is used to highlight no longer pertinent, inaccurate, or wrong text. Browsers render it showing strikethrough text. Its behavior equals the <del> element but is semantically different, <del> is usually used to show document changes.


Suggested change

The **`<s>`** element is used to highlight no longer pertinent, inaccurate, or wrong text. Browsers render it showing strikethrough text. Its behavior equals the <del> element but is semantically different, <del> is usually used to show document changes.

The **`<s>`** element is used to highlight no longer pertinent, inaccurate, or wrong text. Browsers render it showing strike-through text.

Dusch4593 · 2022-11-15T17:12:20Z

content/html/concepts/elements/terms/s/s.md

@@ -0,0 +1,41 @@
+---
+Title: '<s>'
+Description: 'Used to draw attention to one or more words, usually rendered in strikethrough text.'


Suggested change

Description: 'Used to draw attention to one or more words, usually rendered in strikethrough text.'

Description: 'Used to draw attention to one or more words, usually rendered in strike-through text.'

Dusch4593

@Buono-Marco I had a few last comments/suggestions to offer. Could we also rename the image file to something like html-s-element-example.png and replace the old link on line # 47?

Dusch4593 · 2022-11-16T14:23:10Z

content/html/concepts/elements/terms/s/s.md

@@ -0,0 +1,47 @@
+---
+Title: '<s>'
+Description: 'Used to draw attention to one or more words, usually rendered in strike-through text.'


Suggested change

Description: 'Used to draw attention to one or more words, usually rendered in strike-through text.'

Description: 'Represents strike-through text that is no longer need, accurate, or correct.'

Hi @Dusch4593,
is line 5 a refuse?

@Buono-Marco Yes! Sorry for that 😅

Dusch4593 · 2022-11-16T14:23:50Z

content/html/concepts/elements/terms/s/s.md

+  - 'paths/front-end-engineer-career-path'
+---
+
+The **`<s>`** element is used to highlight no longer pertinent, inaccurate, or wrong text. Browsers render it showing strike-through text.


Suggested change

The **`<s>`** element is used to highlight no longer pertinent, inaccurate, or wrong text. Browsers render it showing strike-through text.

The **`<s>`** element represents strike-through text that is no longer needed, accurate, or correct.

Dusch4593 · 2022-11-16T14:26:17Z

content/html/concepts/elements/terms/s/s.md

+
+The rendered output would look like this:
+
+![Rendered <s> tag example](https://raw.githubusercontent.com/Codecademy/docs/main/media/s-tag-example.png)


Suggested change

![Rendered <s> tag example](https://raw.githubusercontent.com/Codecademy/docs/main/media/s-tag-example.png)

![Rendered <s> element example](https://raw.githubusercontent.com/Codecademy/docs/main/media/s-tag-example.png)

Dusch4593 · 2022-11-16T14:27:24Z

content/html/concepts/elements/terms/s/s.md

+
+The `<s>` element should only contain text content or other elements meant for text content.
+
+> **Note:** The `<s>` element is semantically different from the `<del>` element because the former is just an edit while the latter conveys an actual update in a document.


Suggested change

> **Note:** The `<s>` element is semantically different from the `<del>` element because the former is just an edit while the latter conveys an actual update in a document.

> **Note:** The `<s>` element is semantically different from the [`<del>`](https://www.codecademy.com/resources/docs/html/elements/del) element because the former is just an edit while the latter conveys an actual update in a document.

Dusch4593

@Buono-Marco LGTM! 👍🏻

In 3c6893e, I made a small edit to the comment in the "Syntax" section.

github-actions · 2022-11-17T14:34:25Z

👋 @Buono-Marco
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

Dusch4593 · 2022-11-17T14:38:12Z

Congrats and thank you so much for another solid contribution to Codecademy Docs, @Buono-Marco! 🎉 🥳 🎊

The entry should now be live: https://www.codecademy.com/resources/docs/html/elements/s

And hooray! It looks like your Codecademy profile is now visible ☺️

Buono-Marco added 3 commits November 11, 2022 09:48

add element description

4c33fc3

add syntax section

356311c

add example and render sections and add s element example image

dde9f8b

add example and render sections and add s element example image

eaee633

SSwiniarski linked an issue Nov 11, 2022 that may be closed by this pull request

[Entry] HTML: <s> and <del> tags #674

Closed

3 tasks

SSwiniarski added html HTML entries new entry New entry or entries labels Nov 11, 2022

SSwiniarski suggested changes Nov 12, 2022

View reviewed changes

SSwiniarski self-assigned this Nov 12, 2022

SSwiniarski added status: review 1️⃣ completed status: waiting for author labels Nov 12, 2022

SSwiniarski and others added 3 commits November 12, 2022 09:17

Merge branch 'main' into entry-html-s-element

af124f2

Merge branch 'entry-html-s-element' of https://github.com/Buono-Marco…

489dfc3

…/docs into entry-html-s-element

modify tag s description and syntax

3d8e4d0

yangc95 removed the status: waiting for author label Nov 14, 2022

yangc95 requested a review from SSwiniarski November 14, 2022 18:34

SSwiniarski approved these changes Nov 15, 2022

View reviewed changes

Merge branch 'main' into entry-html-s-element

863dd11

Dusch4593 suggested changes Nov 15, 2022

View reviewed changes

Apply the suggested PR changes

39f213f

Dusch4593 suggested changes Nov 16, 2022

View reviewed changes

Dusch4593 added status: review 2️⃣ completed status: waiting for author labels Nov 16, 2022

Dusch4593 self-assigned this Nov 16, 2022

Buono-Marco and others added 2 commits November 17, 2022 09:16

rename image file and apply PR suggestion changes

fbb824e

Update s.md

3c6893e

Dusch4593 approved these changes Nov 17, 2022

View reviewed changes

Merge branch 'main' into entry-html-s-element

d3de5ac

Dusch4593 merged commit a9a761c into Codecademy:main Nov 17, 2022

Dusch4593 removed the status: waiting for author label Nov 17, 2022

	The `<s>` element is used to highlight no more pertinent, accurate, or wrong text. Browsers render it showing strikethrough text. Its behavior equals the <del> element but is semantically different. This last is usually used to show document changes.
	The `<s>` element is used to highlight no longer pertinent, inaccurate, or wrong text. Browsers render it showing strikethrough text. Its behavior equals the <del> element but is semantically different, <del> is usually used to show document changes.

	<!-- Text no more pertinent, accurate, or wrong to here -->
	<!-- No longer pertinent, inaccurate, or wrong text here -->

	Description: 'Used to draw attention to one or more words, usually rendered in strikethrough text.'
	Description: 'Used to draw attention to one or more words, usually rendered in strike-through text.'

	Description: 'Used to draw attention to one or more words, usually rendered in strike-through text.'
	Description: 'Represents strike-through text that is no longer need, accurate, or correct.'

	The `<s>` element is used to highlight no longer pertinent, inaccurate, or wrong text. Browsers render it showing strike-through text.
	The `<s>` element represents strike-through text that is no longer needed, accurate, or correct.


		The rendered output would look like this:

		![Rendered <s> tag example](https://raw.githubusercontent.com/Codecademy/docs/main/media/s-tag-example.png)

	![Rendered <s> tag example](https://raw.githubusercontent.com/Codecademy/docs/main/media/s-tag-example.png)
	![Rendered <s> element example](https://raw.githubusercontent.com/Codecademy/docs/main/media/s-tag-example.png)


		The `<s>` element should only contain text content or other elements meant for text content.

		> Note: The `<s>` element is semantically different from the `<del>` element because the former is just an edit while the latter conveys an actual update in a document.

Entry html s element #1234

Entry html s element #1234

Uh oh!

Conversation

Buono-Marco commented Nov 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Checklist

Uh oh!

CLAassistant commented Nov 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SSwiniarski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SSwiniarski commented Nov 12, 2022

Uh oh!

Buono-Marco commented Nov 14, 2022

Uh oh!

SSwiniarski left a comment

Choose a reason for hiding this comment

Uh oh!

Dusch4593 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dusch4593 left a comment

Choose a reason for hiding this comment

Uh oh!

Dusch4593 Nov 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dusch4593 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 17, 2022

Uh oh!

Buono-Marco commented Nov 11, 2022 •

edited

Loading

CLAassistant commented Nov 11, 2022 •

edited

Loading

Dusch4593 Nov 16, 2022 •

edited

Loading