Skip to content

Conversation

@mattfwilson
Copy link
Contributor

Description

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • [ / ] All writings are my own.
  • [ / ] My entry follows the Codecademy Docs style guide.
  • [ / ] My changes generate no new warnings.
  • [ / ] I have performed a self-review of my own writing and code.
  • [ / ] I have checked my entry and corrected any misspellings.
  • [ / ] I have made corresponding changes to the documentation if needed.
  • [ / ] I have confirmed my changes are not being pushed from my forked main branch.
  • [ / ] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [ / ] Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@caupolicandiaz caupolicandiaz self-requested a review February 23, 2023 20:17
@caupolicandiaz caupolicandiaz added python Python entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Feb 23, 2023
Copy link
Contributor

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattfwilson First review is complete, please review and update. Tag me when your updates are complete. Thanks

mattfwilson and others added 9 commits February 25, 2023 16:41
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattfwilson, I did a second review and only had one comment.

Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattfwilson In the interest of getting this merged, I made the edits myself.

@SSwiniarski SSwiniarski merged commit 277c75f into Codecademy:main Apr 2, 2023
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

👋 @mattfwilson
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

@SSwiniarski
Copy link
Contributor

@mattfwilson congrats on your new entry. Live link is here: https://www.codecademy.com/resources/docs/python/built-in-functions/isinstance

You're currently listed as an anonymous contributor. If you want to be credited follow the instructions below to add your GitHub username to your Codecademy profile. If not, there is nothing more you need to do.

image

To add your GitHub username to your Codecademy profile:

1.) Add your GitHub Username to your Codecademy Profile Details, you can get there on your desktop by pressing on your profile picture in the upper right-hand corner and selecting "Profile" in the drop-down box:

image

2.) Then log out and log back into Codecademy using your GitHub login:

image

Note: Your email used for Codecademy will have to be listed in your GitHub profile for the login feature to properly work. If you use the same email for both GitHub and Codecademy already, then you're set.

@mattfwilson
Copy link
Contributor Author

@SSwiniarski Thanks for your help as well of others who help me through this! This was my first PR so I'm super excited to have officially contributed a tiny piece to Codecademy Docs while also learning more about Git and Python. :)

Pavan-Nambi pushed a commit to Pavan-Nambi/docs that referenced this pull request Apr 12, 2023
* First rev of isinstance() markdown writeup

* Test

* Testing code block example

* Description of example

* Further MD styling

* More styling

* Take two of trying to commit updates/changes from PR

* Update content/python/concepts/functions/terms/isinstance/isinstance.md

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

* Update content/python/concepts/functions/terms/isinstance/isinstance.md

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

* Update content/python/concepts/functions/terms/isinstance/isinstance.md

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

* Update content/python/concepts/functions/terms/isinstance/isinstance.md

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

* Update content/python/concepts/functions/terms/isinstance/isinstance.md

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

* Update content/python/concepts/functions/terms/isinstance/isinstance.md

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

* Update content/python/concepts/functions/terms/isinstance/isinstance.md

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

* review edits

* Update content/python/concepts/built-in-functions/terms/isinstance/isinstance.md

---------

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants