-
Notifications
You must be signed in to change notification settings - Fork 4.3k
PR changes for isinstance() function markdown #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
caupolicandiaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattfwilson First review is complete, please review and update. Tag me when your updates are complete. Thanks
content/python/concepts/functions/terms/isinstance/isinstance.md
Outdated
Show resolved
Hide resolved
content/python/concepts/functions/terms/isinstance/isinstance.md
Outdated
Show resolved
Hide resolved
content/python/concepts/functions/terms/isinstance/isinstance.md
Outdated
Show resolved
Hide resolved
content/python/concepts/functions/terms/isinstance/isinstance.md
Outdated
Show resolved
Hide resolved
content/python/concepts/functions/terms/isinstance/isinstance.md
Outdated
Show resolved
Hide resolved
content/python/concepts/functions/terms/isinstance/isinstance.md
Outdated
Show resolved
Hide resolved
content/python/concepts/functions/terms/isinstance/isinstance.md
Outdated
Show resolved
Hide resolved
content/python/concepts/functions/terms/isinstance/isinstance.md
Outdated
Show resolved
Hide resolved
content/python/concepts/functions/terms/isinstance/isinstance.md
Outdated
Show resolved
Hide resolved
content/python/concepts/functions/terms/isinstance/isinstance.md
Outdated
Show resolved
Hide resolved
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
SSwiniarski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattfwilson, I did a second review and only had one comment.
content/python/concepts/built-in-functions/terms/isinstance/isinstance.md
Outdated
Show resolved
Hide resolved
SSwiniarski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattfwilson In the interest of getting this merged, I made the edits myself.
|
👋 @mattfwilson |
|
@mattfwilson congrats on your new entry. Live link is here: https://www.codecademy.com/resources/docs/python/built-in-functions/isinstance You're currently listed as an anonymous contributor. If you want to be credited follow the instructions below to add your GitHub username to your Codecademy profile. If not, there is nothing more you need to do. To add your GitHub username to your Codecademy profile: 1.) Add your GitHub Username to your Codecademy Profile Details, you can get there on your desktop by pressing on your profile picture in the upper right-hand corner and selecting "Profile" in the drop-down box: 2.) Then log out and log back into Codecademy using your GitHub login: Note: Your email used for Codecademy will have to be listed in your GitHub profile for the login feature to properly work. If you use the same email for both GitHub and Codecademy already, then you're set. |
|
@SSwiniarski Thanks for your help as well of others who help me through this! This was my first PR so I'm super excited to have officially contributed a tiny piece to Codecademy Docs while also learning more about Git and Python. :) |
* First rev of isinstance() markdown writeup * Test * Testing code block example * Description of example * Further MD styling * More styling * Take two of trying to commit updates/changes from PR * Update content/python/concepts/functions/terms/isinstance/isinstance.md Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com> * Update content/python/concepts/functions/terms/isinstance/isinstance.md Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com> * Update content/python/concepts/functions/terms/isinstance/isinstance.md Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com> * Update content/python/concepts/functions/terms/isinstance/isinstance.md Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com> * Update content/python/concepts/functions/terms/isinstance/isinstance.md Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com> * Update content/python/concepts/functions/terms/isinstance/isinstance.md Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com> * Update content/python/concepts/functions/terms/isinstance/isinstance.md Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com> * review edits * Update content/python/concepts/built-in-functions/terms/isinstance/isinstance.md --------- Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com> Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>



Description
Type of Change
Checklist
mainbranch.