Skip to content

Conversation

MMMMMMMZ
Copy link
Contributor

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@CLAassistant
Copy link

CLAassistant commented May 12, 2023

CLA assistant check
All committers have signed the CLA.

@SSwiniarski SSwiniarski linked an issue May 13, 2023 that may be closed by this pull request
3 tasks
@SSwiniarski SSwiniarski self-assigned this May 13, 2023
@SSwiniarski SSwiniarski added php PHP entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels May 13, 2023
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MMMMMMMZ I did a first review and left a few comments.

Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MMMMMMMZ Aside from one extra space, looks good for a second review.

@MMMMMMMZ
Copy link
Contributor Author

MMMMMMMZ commented May 14, 2023

@SSwiniarski ok, is it ready now for the second review?

MMMMMMMZ and others added 12 commits May 14, 2023 16:03
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Copy link
Contributor

@KTom101 KTom101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MMMMMMMZ I've added a second review.

@KTom101 KTom101 self-assigned this May 27, 2023
@SSwiniarski
Copy link
Contributor

@MMMMMMMZ I did a fix to the filename (it was missing the ".md") and ran an npm format so the linting checks would pass. This should be ready to merge once @KTom101 reviews again and approves your edits.

@SSwiniarski SSwiniarski requested a review from KTom101 May 28, 2023 14:25
Copy link
Contributor

@KTom101 KTom101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MMMMMMMZ Looks good 👍

@SSwiniarski SSwiniarski merged commit 245163f into Codecademy:main May 30, 2023
@github-actions
Copy link

👋 @MMMMMMMZ
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

@KTom101
Copy link
Contributor

KTom101 commented May 30, 2023

@MMMMMMMZ Live link is here: https://www.codecademy.com/resources/docs/php/string-functions/str-repeat

Currently, you're listed as an anonymous contributor:

Screenshot 2023-05-30 at 12 21 04 PM

If you want to remain anonymous, there is nothing more you need to do. If you wish to be listed as a contributor, make sure you've added your GitHub username to your Codecademy profile using the following steps:

1.) Add your GitHub Username to your Codecademy Profile Details, you can get there on your desktop by pressing on your profile picture in the upper right-hand corner and selecting "Profile" in the drop-down box:

YourGitHubName

2.) Then log out and log back into Codecademy using your GitHub login:

ReLogIn

Note: Your email used for Codecademy will have to be listed in your GitHub profile for the login feature to properly work. If you use the same email for both GitHub and Codecademy already, then you're set.

cc @yangc95 @SSwiniarski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Term Entry] PHP String Functions str_repeat()

4 participants