Create number-format.md, closes #3219 #3240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created number-format.md on filepath docs/content/php/concepts/string-functions/terms/number-format/number-format.md - Added Title, Description, Subjects, Tags, and Catalog Content - Added description, syntax, example, and codebyte example - Ran through 3 online plagiarism checkers to ensure 100% unique wording and description, passed with 100% - Followed content and style guidelines -Checked for spelling and grammar errors
Ran yarn format:all to pass verify lint and formatting
….com/reganmarie/docs into PHP-String-Functions-number_format()
caupolicandiaz
added
php
caupolicandiaz
suggested changes
Sep 12, 2023
There was a problem hiding this comment.
@reganmarie I've completed my initial review. Please update the entry, and tag me when you've finished making changes. Thanks
| @@ -0,0 +1,54 @@ | |||
| --- | |||
| Title: 'number_format()' | |||
| Description: 'Formats a number with grouped thousands' | |||
There was a problem hiding this comment.
Suggested change
| Description: 'Formats a number with grouped thousands' | |
| Description: 'Returns a given value formatted with grouped thousands.' |
| Subjects: | ||
| - 'Computer Science' | ||
| - 'Web Design' | ||
| - 'Web Development' |
There was a problem hiding this comment.
Suggested change
| - 'Web Development' |
There was a problem hiding this comment.
there should only be two items under subjects
|
|
||
| - `number`: The number to format. | ||
| - `decimals`: Optional argument that sets the number of digits after the decimal point. If not given, the number returned will be a whole number. | ||
| - `decimal_point`: Optional argument that specifies the decimal separator and should be given in string format. |
There was a problem hiding this comment.
Suggested change
| - `decimal_point`: Optional argument that specifies the decimal separator and should be given in string format. | |
| - `decimal_point`: Optional parameter that specifies the decimal separator and should be given as a string. |
| - `number`: The number to format. | ||
| - `decimals`: Optional argument that sets the number of digits after the decimal point. If not given, the number returned will be a whole number. | ||
| - `decimal_point`: Optional argument that specifies the decimal separator and should be given in string format. | ||
| - `separator`: Optional argument that specifies the thousands separator and should be given in string format. |
There was a problem hiding this comment.
Suggested change
| - `separator`: Optional argument that specifies the thousands separator and should be given in string format. | |
| - `separator`: Optional parameter that specifies the thousands separator and should be given as a string. |
| ?> | ||
| ``` | ||
|
|
||
| This is the output for the above example: |
There was a problem hiding this comment.
Suggested change
| This is the output for the above example: | |
| This will result in the following output: |
|
|
||
| ```codebyte/php | ||
| <?php | ||
| echo number_format("500000"); |
There was a problem hiding this comment.
Suggested change
| echo number_format("500000"); | |
| echo number_format("500000"), "\n"; |
|
|
||
| ## Codebyte Example | ||
|
|
||
| The following codebyte example can be run and calls the `number_format()` method two times. The second call uses the optional `decimals`, `decimal_point`, and `separator` arguments. |
There was a problem hiding this comment.
Suggested change
| The following codebyte example can be run and calls the `number_format()` method two times. The second call uses the optional `decimals`, `decimal_point`, and `separator` arguments. | |
| The following codebyte example can be run and calls the `number_format()` method two times. The second call uses the optional `decimals`, `decimal_point`, and `separator` parameters. |
caupolicandiaz
added
status: review 1️⃣ completed
status: waiting for author
and removed
status: under review
- Changed Description - Removed a subject so there are only two - Changed argument to parameter - Changed "given in string format" to "given as a string" - Changed output wording to "this will result in the following output" - Added new line to Codebyte example - Changed 'arguments' to 'parameters' in Codebyte explanation
|
@caupolicandiaz I didn't want to spam your inbox by responding to each individual revision, so these are the changes I made in the latest commit!
|
3 tasks
caupolicandiaz
approved these changes
Sep 13, 2023
caupolicandiaz
added
status: ready for next review
and removed
status: waiting for author
labels
|
Thank you @caupolicandiaz 😊 |
SSwiniarski
approved these changes
Sep 17, 2023
|
👋 @reganmarie 🎉 Your contribution(s) can be seen here: https://www.codecademy.com/resources/docs/php/string-functions/number-format Please note it may take a little while for changes to become visible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
mainbranch.