Skip to content

for the issue: [Entry] Variables: Creating new concept entry variables.md #4237 #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ishg-153 merged 16 commits into from
May 15, 2024
Merged

for the issue: [Entry] Variables: Creating new concept entry variables.md #4237 #4428

ishg-153 merged 16 commits into from
May 15, 2024

Conversation

@zkhOlga
Copy link
Contributor

@zkhOlga zkhOlga commented Feb 29, 2024 •
edited
Loading

Description

The new entry variables.md is created for Dart

Issue Solved

Closes #4237

Type of Change

  • Adding a new entry under the path: docs/content/dart/concepts/variables/variables.md

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Feb 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zkhOlga zkhOlga closed this Feb 29, 2024
@zkhOlga zkhOlga reopened this Feb 29, 2024
@zkhOlga zkhOlga marked this pull request as draft February 29, 2024 17:19
@zkhOlga zkhOlga marked this pull request as ready for review February 29, 2024 17:19
@dakshdeepHERE dakshdeepHERE self-assigned this Mar 6, 2024
@dakshdeepHERE dakshdeepHERE added dart Dart entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Mar 6, 2024
dakshdeepHERE
dakshdeepHERE reviewed Mar 8, 2024
View reviewed changes
dakshdeepHERE
dakshdeepHERE requested changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few comments for you to work on. Overall amazing entry.

content/dart/concepts/variables/variables.md Outdated
Object name = 'value';
```

The Dart Language enforces sound null safety, allowes to set default values, constants and to declare the late variables (for more details see https://dart.dev/language/variables#default-value).
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking something outside of codecademy platform isn't allowed. Let's remove this hyperlink.

zkhOlga
zkhOlga commented Mar 11, 2024
View reviewed changes
Copy link
Contributor Author

@zkhOlga zkhOlga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestions from the code review are implemented

@zkhOlga zkhOlga requested a review from dakshdeepHERE March 11, 2024 10:25
dakshdeepHERE
dakshdeepHERE approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ishg-153 ishg-153 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Mar 15, 2024
@ishg-153 ishg-153 self-assigned this Mar 15, 2024
ishg-153
ishg-153 suggested changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zkhOlga Suggested changes to the syntax section. Everything else looks great.

Sorry for the delayed review.

content/dart/concepts/variables/variables.md Outdated
When declaring a variable in Dart, the type of variable goes first, followed by the name, and then the value:

```pseudo
type name = 'value';
Copy link
Contributor

@ishg-153 ishg-153 Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type name = 'value';
type name = value;

So that value can be any data type.

content/dart/concepts/variables/variables.md Outdated
type name = 'value';
```

The default type 'var' is inferred to be a `string`. If an object isn't restricted to a single type, specify the Object type (or dynamic if necessary):
Copy link
Contributor

@ishg-153 ishg-153 Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are adding all the values of type can take above, let's make this a note.
> **Note:** text inside note

@ishg-153
Copy link
Contributor

ishg-153 commented Apr 9, 2024

@zkhOlga How are the suggested changes coming along?

@ishg-153
Copy link
Contributor

ishg-153 commented May 8, 2024

Due to lack of response from @zkhOlga I'm moving forward by making the changes

ishg-153
ishg-153 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge.

@ishg-153 ishg-153 merged commit ac0d22c into Codecademy:main May 15, 2024
@github-actions
Copy link

github-actions bot commented May 15, 2024

👋 @zkhOlga
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/dart/variables

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakshdeepHERE dakshdeepHERE dakshdeepHERE approved these changes

+2 more reviewers

@ishg-153 ishg-153 ishg-153 approved these changes

@hejoefs hejoefs hejoefs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ishg-153 ishg-153

@dakshdeepHERE dakshdeepHERE

Labels

dart Dart entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Entry] Variables: Creating new concept entry variables.md

5 participants

@zkhOlga @CLAassistant @ishg-153 @dakshdeepHERE @hejoefs