Skip to content

Conversation

@KarinaNi
Copy link
Contributor

@KarinaNi KarinaNi commented Jun 19, 2024

Description

Added documentation of scatter md

Issue Solved

Closes #4558

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • [x ] All writings are my own.
  • [ x] My entry follows the Codecademy Docs style guide.
  • [ x] My changes generate no new warnings.
  • [x ] I have performed a self-review of my own writing and code.
  • [x ] I have checked my entry and corrected any misspellings.
  • [x ] I have made corresponding changes to the documentation if needed.
  • [ x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x ] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x ] I have linked any issues that are relevant to this PR in the Issues Solved section.

@KarinaNi
Copy link
Contributor Author

KarinaNi commented Jun 19, 2024

image
Should I update the branch or no? @mamtawardhani

@mamtawardhani mamtawardhani self-assigned this Jun 19, 2024
@mamtawardhani
Copy link
Collaborator

No worries @KarinaNi i'll do that. Thanks for the entry, will review it asap 😃

@mamtawardhani mamtawardhani added the new entry New entry or entries label Jun 19, 2024
@mamtawardhani mamtawardhani added status: under review Issue or PR is currently being reviewed plotly Python:Plotly entries labels Jun 19, 2024
minor changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KarinaNi the entry is well written. I'm requesting just one change, the output image for the second example seems incorrect, could you please run that code and attach the correct image for the output of the second example? Thank you! 😃

@KarinaNi
Copy link
Contributor Author

what do you think @mamtawardhani

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfecto spectronium @KarinaNi! Many thanks for making the required changes 😃

Looks good for a second round of review 🚀

Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @KarinaNi! 👍

@Sriparno08 Sriparno08 merged commit c16c1e3 into Codecademy:main Jun 19, 2024
@github-actions
Copy link

👋 @KarinaNi
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/plotly/express/scatter

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Term Entry] Python Plotly .scatter()

3 participants