chore(DatePicker): Address Left/Right arrows in calendar for RTL#3335
Merged
aresnik11 merged 1 commit intoajr-datepicker-localizationfrom Apr 30, 2026
Merged
chore(DatePicker): Address Left/Right arrows in calendar for RTL#3335aresnik11 merged 1 commit intoajr-datepicker-localizationfrom
aresnik11 merged 1 commit intoajr-datepicker-localizationfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 344d8d4 ☁️ Nx Cloud last updated this comment at |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
|
🚀 Styleguide deploy preview ready! Preview URL: https://69f35c2d98712390e60d2c04--gamut-preview.netlify.app |
Collaborator
|
📬 Published Alpha Packages:
|
761cecf
into
ajr-datepicker-localization
13 of 14 checks passed
aresnik11
added a commit
that referenced
this pull request
May 4, 2026
* calendar phase 1 * add focus management * add input * datepicker * clean up * refactor datepicker * clean up hooks * update exports * add missing validation file * clean up inputref * wip fix for typing date * cleaning up * update range logic * range logic when specific input is focused * deselect logic * fix lint * fix story * fix lint again * update snapshot * fix lint * show 2 months on larger screens * style updates * PR feedback * fix today in range color * clean up context * update placeholder text to be locale based * update next/last month text to be locale based * capitalize * translations * add formgroup * fix calendar alignment and add shadow * clear button logic * more translations * fix disabled hover * make disabledDates optional and add to story * disabled date in range logic * fix keyboard nav now that showing 2 months * PR feedback * toLocaleUpperCase * small fixes * fix range styling * fix alignments * rename props * move around helpers * fix calendar story * support small input size * initial focus a11y updates * PR feedback * clean up utils * add full date aria label to date cells * move around files and clean up exports * update locale * week starts on from locale + polyfill * remove button from DateCell * refactor CalendarHeader * fix errors * fix ci errors * input segments * fix segments typing * dedupe and format * version plan * fix sb import * tests round 1 * CalendarBody tests * style updates * utils tests * segmentUtils tests * segment tests * fix segment refs * close on date select * fix focus & active range part * move DatePicker to organism * WIP mdx file * quick actions * evan pr feedback * dont render empty border in footer * first passthrough of PR feedback * reorg files * update disabled date logic * fix icon button tip sticking around * discriminated union context * change to object syntax * PR feedback * fix date keyboard nav * more tests & tweaks * more tests * sync segment input and calendar month shown * pr feedback * fix bugs * id clean up * always close calendar on escape * form tests * remove robo comments * prop comments and clean up * rename to disableDate * update SB docs * chore(DatePicker): Address Left/Right arrows in calendar for RTL (#3335) address left/right buttons in calendar for RTL * fix failing test * rtl for arrow icon * PR feedback * add placement * change breakpoint * add code example to docs * add height to stories * more doc clean ups * change more to floating and use decorator * Update packages/styleguide/src/lib/Organisms/DatePicker/DatePicker.mdx Co-authored-by: Kenny Lin <kenny.lin.91@gmail.com> * Update packages/styleguide/src/lib/Organisms/DatePicker/DatePicker.mdx Co-authored-by: Kenny Lin <kenny.lin.91@gmail.com> * PR feedback --------- Co-authored-by: Kenny Lin <kenny.lin.91@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs