Skip to content

Conversation

@richTrash21
Copy link
Contributor

Adds onCloseSubState script event for MusicBeatSubstates. Basicaly #789 but for substates lol

@ItsLJcool
Copy link
Contributor

yes this would be nice... if only there was an onClose event callback because this is already implemented :trollface:
https://github.com/CodenameCrew/CodenameEngine/blob/main/source/funkin/backend/MusicBeatSubstate.hx#L161

@ItsLJcool
Copy link
Contributor

the only reason I added it into MusicBeatState because there was no physical event that was called when the SubState closed. This is not true for the MusicBeatSubState. This does prove useful however for substate substates, so I still think it's a valid pr

@richTrash21
Copy link
Contributor Author

This does prove useful however for substate substates

Thats why I made this pr! I'm using onOpenSubState/onCloseSubState to turn on/off mouse events on menu buttons and one of the menus is a substate... that can open other substate menu. 😅😅

@Raltyro Raltyro merged commit 3720bc1 into CodenameCrew:main Nov 16, 2025
@richTrash21 richTrash21 deleted the feature/close-substate branch November 16, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants