Skip to content

Conversation

@CoderPat
Copy link
Owner

@CoderPat CoderPat commented Apr 11, 2019

Fixes #1 ,#3, #4, #5 and #7, #12.

@ioana-blue
Copy link

Can't comment on the script that generates the graph, the rest look good to me. Thanks for your help!

@ioana-blue
Copy link

Note problem explained here:
#4 (comment)

@shellycsy
Copy link

Can't comment on the script that generates the graph, the rest look good to me. Thanks for your help!

Have you finished the experiment?

@CoderPat CoderPat merged commit 0bcb78e into master Apr 22, 2019
@CoderPat CoderPat deleted the dev/fix-issues branch April 23, 2019 09:49
Copy link

@ioana-blue ioana-blue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at line 445/444, I get an error because I think the iterator now produces only features without labels as you removed the labels_file from the input function but you're still unpacking it from the iterator. Taking an educated guess, labels should disappear from line 444

And also probably remove labels from the call to model. I think it should work fine with None for labels since it's calling the model in inference mode.

@ioana-blue
Copy link

ioana-blue commented Apr 23, 2019

What I see is that TF is not happy with dealing with None tensors, so a workaround may be necessary to pass in None as labels. Passing an empty dictionary should work. This means changing the code in the OpenGNN to account for empty labels as opposed to None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential typo in the instructions in the README

4 participants