🐛 fix(store): unconditional tagPrecision repair on startup and outside try-catch (#270)

- Add repairDataOnStartup() that backfills missing tagPrecision on
  every startup, independent of the version migration gate
- Extract backfillStoredTagPrecision() and call it before the
  image-inspect try-catch so a failed getImage().inspect() no longer
  silently prevents the backfill

Author: s-b-e-n-s-o-n

app/store/app.ts

@@ -3,7 +3,7 @@
  */
 import * as migrate from './migrate.js';
 
-const { migrate: migrateData } = migrate;
+const { migrate: migrateData, repairDataOnStartup } = migrate;
 
 import { getVersion } from '../configuration/index.js';
 import { initCollection } from './util.js';
@@ -39,6 +39,7 @@ function saveAppInfosAndMigrate() {
   if (currentVersion !== versionFromStore) {
     migrateData(versionFromStore, currentVersion);
   }
+  repairDataOnStartup();
   if (appInfosSaved) {
     app.remove(appInfosSaved);
   }

app/store/migrate.ts

@@ -44,6 +44,10 @@ function shouldBackfillMissingTagPrecision(from?: string, to?: string) {
   return semver.valid(from) ? semver.lt(from, TAG_PRECISION_BACKFILL_VERSION) : true;
 }
 
+export function repairDataOnStartup() {
+  backfillMissingTagPrecision();
+}
+
 /**
  * Data migration function.
  * @param from version

app/watchers/providers/docker/docker-image-details-orchestration.ts

@@ -230,6 +230,15 @@ function reconcileStoredContainerStatus(
   }
 }
 
+function backfillStoredTagPrecision(containerInStore: Container) {
+  if (containerInStore.image?.tag && containerInStore.image.tag.tagPrecision === undefined) {
+    containerInStore.image.tag.tagPrecision = classifyTagPrecision(
+      containerInStore.image.tag.value,
+      containerInStore.transformTags,
+    );
+  }
+}
+
 async function refreshStoredContainerImageFields(
   watcher: DockerImageDetailsWatcher,
   container: DockerContainerSummary,
@@ -239,6 +248,8 @@ async function refreshStoredContainerImageFields(
   containerInStore: Container,
   containerInspect: DockerContainerInspectPayload | undefined,
 ) {
+  backfillStoredTagPrecision(containerInStore);
+
   try {
     const currentImage = await watcher.dockerApi.getImage(container.Image).inspect();
     const freshDigestRepo = getRepoDigest(currentImage);
@@ -298,13 +309,6 @@ async function refreshStoredContainerImageFields(
       }
     }
 
-    if (containerInStore.image?.tag && containerInStore.image.tag.tagPrecision === undefined) {
-      containerInStore.image.tag.tagPrecision = classifyTagPrecision(
-        containerInStore.image.tag.value,
-        containerInStore.transformTags,
-      );
-    }
-
     // Keep local digest value populated for digest-watch containers, even when
     // image id/repo digest are unchanged from cached state.
     if (freshDigestRepo !== undefined && containerInStore.image.digest.value === undefined) {