Skip to content

Conversation

@kien-cs
Copy link
Contributor

@kien-cs kien-cs commented Apr 6, 2023

This will add a new example to show customer on how to integrate with CodeSee using Serverless Framework + Golang + AL2.

Comment on lines 3 to 20
# Refer to https://github.com/golang/dep/blob/master/docs/Gopkg.toml.md
# for detailed Gopkg.toml documentation.
#
# required = ["github.com/user/thing/cmd/thing"]
# ignored = ["github.com/user/project/pkgX", "bitbucket.org/user/project/pkgA/pkgY"]
#
# [[constraint]]
# name = "github.com/user/project"
# version = "1.0.0"
#
# [[constraint]]
# name = "github.com/user/project2"
# branch = "dev"
# source = "github.com/myfork/project2"
#
# [[override]]
# name = "github.com/x/y"
# version = "2.4.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comments meant to be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope will remove

DD_APM_NON_LOCAL_TRAFFIC: true
DD_APM_ENABLED: true

CODESEE_ENABLE_ACCESS_LOGS: true # DEBUG - turn off in Prod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt everyone will read things carefully. Maybe we set this to false but leave a comment to "turn on for debug logging for codesee layer"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will flip around

Comment on lines +15 to +21
```
DD_APM_DD_URL: http://127.0.0.1:8080
DD_APM_NON_LOCAL_TRAFFIC: true
DD_APM_ENABLED: true
CODESEE_BRIDGE_FORWARD_HOST: https://in-datadog.codesee.io
CODESEE_BRIDGE_TOKEN: <YOUR_CODESEE_TOKEN>
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a little more information here?

Should these be set in certain files of the example? Or set via some other method? I feel like I've seen several of these in the code. If they are already set in the code, why are we also listing them here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're telling the user to make sure these are set properly in the serverless.yml, is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea I'll add the note: Make sure the following environment variables are set in your serverless.yml file.

Copy link
Contributor

@jleven jleven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@kien-cs kien-cs merged commit f833906 into main Apr 6, 2023
@kien-cs kien-cs deleted the serverless-al2-example branch April 6, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants