-
Notifications
You must be signed in to change notification settings - Fork 0
Adding Serverless + Golang + AL2 + CodeSee example #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
serverless-al2-example/Gopkg.toml
Outdated
| # Refer to https://github.com/golang/dep/blob/master/docs/Gopkg.toml.md | ||
| # for detailed Gopkg.toml documentation. | ||
| # | ||
| # required = ["github.com/user/thing/cmd/thing"] | ||
| # ignored = ["github.com/user/project/pkgX", "bitbucket.org/user/project/pkgA/pkgY"] | ||
| # | ||
| # [[constraint]] | ||
| # name = "github.com/user/project" | ||
| # version = "1.0.0" | ||
| # | ||
| # [[constraint]] | ||
| # name = "github.com/user/project2" | ||
| # branch = "dev" | ||
| # source = "github.com/myfork/project2" | ||
| # | ||
| # [[override]] | ||
| # name = "github.com/x/y" | ||
| # version = "2.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these comments meant to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope will remove
| DD_APM_NON_LOCAL_TRAFFIC: true | ||
| DD_APM_ENABLED: true | ||
|
|
||
| CODESEE_ENABLE_ACCESS_LOGS: true # DEBUG - turn off in Prod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt everyone will read things carefully. Maybe we set this to false but leave a comment to "turn on for debug logging for codesee layer"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will flip around
| ``` | ||
| DD_APM_DD_URL: http://127.0.0.1:8080 | ||
| DD_APM_NON_LOCAL_TRAFFIC: true | ||
| DD_APM_ENABLED: true | ||
| CODESEE_BRIDGE_FORWARD_HOST: https://in-datadog.codesee.io | ||
| CODESEE_BRIDGE_TOKEN: <YOUR_CODESEE_TOKEN> | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a little more information here?
Should these be set in certain files of the example? Or set via some other method? I feel like I've seen several of these in the code. If they are already set in the code, why are we also listing them here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're telling the user to make sure these are set properly in the serverless.yml, is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea I'll add the note: Make sure the following environment variables are set in your serverless.yml file.
jleven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
This will add a new example to show customer on how to integrate with CodeSee using Serverless Framework + Golang + AL2.