-
Notifications
You must be signed in to change notification settings - Fork 14
Add .NET 10.0 support to all projects and CI workflow #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds .NET 10.0 as a target framework to support multi-targeting across all projects in the OpenXmlPowerTools solution and updates GitHub Actions workflows to include .NET 10.0 SDK installation.
- Adds net10.0 to TargetFrameworks alongside existing net8.0
- Updates CI/CD workflows to install both .NET 8.0.x and 10.0.x SDKs
- Changes TargetFramework to TargetFrameworks (plural) where applicable
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| OpenXmlPowerTools/OpenXmlPowerTools.csproj | Adds net10.0 target framework to main library |
| OpenXmlPowerTools.Tests/OpenXmlPowerTools.Tests.csproj | Adds net10.0 target framework to test project |
| OpenXmlPowerToolsExamples/*/*.csproj (33 files) | Adds net10.0 target framework to all example projects |
| .github/workflows/dotnet.yml | Updates workflow to install both .NET 8 and 10 SDKs across all jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate TargetFrameworks entries. Remove the duplicate line 5 to avoid potential build configuration issues.
| <TargetFrameworks>net8.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate TargetFrameworks entries. Remove the duplicate line 5 to avoid potential build configuration issues.
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> |
| <TargetFrameworks>net8.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate TargetFrameworks entries. Remove the duplicate line 5 to avoid potential build configuration issues.
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> |
| <TargetFrameworks>net8.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate TargetFrameworks entries. Remove the duplicate line 5 to avoid potential build configuration issues.
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> |
| <TargetFrameworks>net8.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate TargetFrameworks entries. Remove the duplicate line 6 to avoid potential build configuration issues.
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> |
Overview
This PR adds .NET 10.0 support to all project files in the repository and updates the GitHub Actions CI workflow to build and test against .NET 10 when it becomes available.
Changes Made
Project Files (34 files)
OpenXmlPowerTools.csproj): UpdatedTargetFrameworksto includenet10.0OpenXmlPowerTools.Tests.csproj): UpdatedTargetFrameworksto includenet10.0net8.0andnet10.0All projects now use the format:
GitHub Actions Workflow
Updated
.github/workflows/dotnet.ymlto configure both .NET SDK versions across all jobs:The workflow now uses multi-line SDK configuration:
Impact
Current Behavior
Future Behavior
Once .NET 10 SDK is released:
Notes
net10.0will fail with error NETSDK1045 until the SDK becomes available. This is expected behavior and does not affect existing .NET 8.0 functionality.The changes are minimal and surgical - only the
TargetFrameworksproperties were modified to add net10.0 support, ensuring the repository is ready for the next .NET release.Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.