Skip to content

Prevent internal API retries for timing out action run before input timeout is exceeded #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 26, 2024
Merged

Prevent internal API retries for timing out action run before input timeout is exceeded #247

merged 5 commits into from
Sep 26, 2024

Conversation

@Codex-
Copy link
Owner

@Codex- Codex- commented Sep 26, 2024 •
edited
Loading

Fixes: #245

Changes

  • Refactor retryOrDie to retryOrTimeout
    • Provide result instead of throwing
  • [Backport] Fix some incorrect API logging
  • Exit more gracefully instead of throwing to exit for handled failures

@Codex- Codex- marked this pull request as ready for review September 26, 2024 22:43
@Codex- Codex- merged commit c4f21b7 into main Sep 26, 2024
@Codex- Codex- deleted the backport_retry_fix branch September 26, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Getting "Timed out while attempting to fetch data" & Runs fetched coming as empty Array[]

2 participants

@Codex-