a joke slash command #21
Conversation
|
This is a great demo for quiz-like interactions which wait for the user response. (Though, the repo is being reworked for supplementing the videos) |
|
Have you tested this code? Some of the things in there don't look like they're going to do what you intended them to do 😅 |
|
I have tested it in my server and it seems to be doing what I intended. The one issue I am having is that the bot.js file asks about feelings. What are you concerned about? |
01-discordjs/commands/jokes.js
Outdated
| ); | ||
|
|
||
| const filter = (response) => { | ||
| return jokes[`${i}`].punchline.some( |
There was a problem hiding this comment.
You don't need to put i in a string! You can just do jokes[i], behind the scenes it will automatically convert it back to a number anyways as the index is a number here! So you're going from number -> string -> back to number
There was a problem hiding this comment.
Thanks, I have updated that.
01-discordjs/commands/jokes.js
Outdated
| ); | ||
| }; | ||
|
|
||
| const answer = jokes[`${i}`].punchline; |
01-discordjs/commands/jokes.js
Outdated
| await interaction | ||
| .reply({ | ||
| content: jokes[`${i}`].joke, | ||
| fetchReply: true, | ||
| }) | ||
| .then(() => { | ||
| interaction.channel | ||
| .awaitMessages({ | ||
| filter, | ||
| max: 1, | ||
| time: 30000, // Allow user response for 30 seconds | ||
| errors: ["time"], | ||
| }) | ||
| .then((collected) => { | ||
| interaction.followUp(`${collected.first().author} you got it right!`); | ||
| }) | ||
| .catch((collected) => { | ||
| interaction.followUp( | ||
| `Sorry, that isn't right. The punchline is ${answer}` | ||
| ); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
| await interaction | |
| .reply({ | |
| content: jokes[`${i}`].joke, | |
| fetchReply: true, | |
| }) | |
| .then(() => { | |
| interaction.channel | |
| .awaitMessages({ | |
| filter, | |
| max: 1, | |
| time: 30000, // Allow user response for 30 seconds | |
| errors: ["time"], | |
| }) | |
| .then((collected) => { | |
| interaction.followUp(`${collected.first().author} you got it right!`); | |
| }) | |
| .catch((collected) => { | |
| interaction.followUp( | |
| `Sorry, that isn't right. The punchline is ${answer}` | |
| ); | |
| }); | |
| }); | |
| await interaction | |
| .reply({ | |
| content: jokes[i].joke, | |
| fetchReply: true, | |
| }) | |
| const collected = await interaction.channel | |
| .awaitMessages({ | |
| filter, | |
| max: 1, | |
| time: 30000, // Allow user response for 30 seconds | |
| errors: ["time"], | |
| }).catch(() => interaction.followUp( | |
| `Sorry, that isn't right. The punchline is ${answer}` | |
| )); | |
| // If nothing got collected so it probably timed out and got handled by the catch above, do nothing... | |
| if (!collected) return; | |
| // They got it right! | |
| await interaction.followUp(`${collected.first().author} you got it right!`); |
There was a problem hiding this comment.
You don't need all the .then() when we're working with async/await! Generally .then() is used when we don't have the luxury of an async function but we totally do in this case! My formatting might be off here as I used github it's internal editor to do this so you might want to perform those changes yourself. Ialso modified the reply code to address what I mentioned in my earlier review comments about the i variable being allowed in a string!
01-discordjs/commands/jokes.js
Outdated
| const row = new ActionRowBuilder().addComponents( | ||
| new StringSelectMenuBuilder() | ||
| .setCustomId("random-joke") | ||
| .setPlaceholder("Can you answer the joke?") | ||
| .setMinValues(1) | ||
| .setMaxValues(1) | ||
| .addOptions( | ||
| new StringSelectMenuOptionBuilder() | ||
| .setLabel(`jokes[${i}]`) | ||
| .setDescription(`Joke ${i}`) | ||
| .setValue( | ||
| `jokes[${i}].punchline.some(answer => answer.toLowerCase() === response.content.toLowerCase())` | ||
| ) | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Is this code used anywhere? I'm either blind or it's just here without any actual reason?
That's correct! In the current version of the repository the bot.js contains some additional code Dan tinkered with which did that when you mentioned the bot. |
|
Hi @kfahn22 this is great! I was about to merge #20. The idea here is that this repo would have the code to match the videos precisely. Other bots or examples would come in future videos and then could be added to the repo. Also, we can create a section in the README to link to other examples or "passenger showcase" bots (though these would ultimately be on the website as well?). How about linking to your own repo from the README here for now? |
|
I really just wanted to share the code. I realized that you wanted a clean repo with just basics. I am not sure it makes sense to put a link in the README? Should I close pull request and send you a link instead just in case you want to use i? |
|
I think this (closed) pr with Supercrafter's comments can be used as a reference later in case Dan wants to refer to it? |
4 participants
Oops, I didn't realize my auto-formatter apparently is set to use "" instead of ''