-
Notifications
You must be signed in to change notification settings - Fork 0
Draw ER diagram #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draw ER diagram #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new Mermaid ER diagram for the database schema as part of drawing the ER diagram (Resolves #29).
- Added ER diagram definitions for various database entities such as users, contests, problems, and related associations.
- Established relationships among key tables using Mermaid syntax.
Comments suppressed due to low confidence (2)
assets/database.mmd:46
- Consider using a consistent type for role fields across tables. The SOLUTION table uses 'enum role' while PROBLEM_AUTHOR and CONTEST_AUTHOR declare role as a string with enumerated options.
enum role
assets/database.mmd:96
- Review whether the 'char' type is sufficient for the alias field in CONTEST_PROBLEM, as multi-character aliases may require the use of a string type instead.
char alias "A/B/C…"
reddevilmidzy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PROBLEM_AUTHOR랑 CONTEST_AUTHOR의 role은 string 타입이고,
SOLUTION의 role은 enum인데 둘이 다른 타입으로 만든 이유가 있을까요?
서로 다른 테이블이라 크게 상관은 없을 거 같긴한데 enum으로 통일하는 것도 좋을 것 같습니다!
PROBLEM_AUTHOR랑 CONTEST_AUTHOR의 role은 삭제해도 될 거 같네요. 저건 Codeforces에서는 필요한 게 맞는데 일반적인 대회 세팅에서는 불필요해 보입니다. 퇴근하고 삭제할게요. |
삭제했습니다. |
This revision includes: