Skip to content

Conversation

@utilForever
Copy link
Member

This revision includes:

@utilForever utilForever linked an issue Jun 30, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Mermaid ER diagram for the database schema as part of drawing the ER diagram (Resolves #29).

  • Added ER diagram definitions for various database entities such as users, contests, problems, and related associations.
  • Established relationships among key tables using Mermaid syntax.
Comments suppressed due to low confidence (2)

assets/database.mmd:46

  • Consider using a consistent type for role fields across tables. The SOLUTION table uses 'enum role' while PROBLEM_AUTHOR and CONTEST_AUTHOR declare role as a string with enumerated options.
        enum role

assets/database.mmd:96

  • Review whether the 'char' type is sufficient for the alias field in CONTEST_PROBLEM, as multi-character aliases may require the use of a string type instead.
        char alias "A/B/C…"

w8385
w8385 previously approved these changes Jun 30, 2025
reddevilmidzy
reddevilmidzy previously approved these changes Jul 1, 2025
Copy link
Member

@reddevilmidzy reddevilmidzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PROBLEM_AUTHOR랑 CONTEST_AUTHOR의 role은 string 타입이고,
SOLUTION의 role은 enum인데 둘이 다른 타입으로 만든 이유가 있을까요?
서로 다른 테이블이라 크게 상관은 없을 거 같긴한데 enum으로 통일하는 것도 좋을 것 같습니다!

@utilForever
Copy link
Member Author

PROBLEM_AUTHOR랑 CONTEST_AUTHOR의 role은 string 타입이고, SOLUTION의 role은 enum인데 둘이 다른 타입으로 만든 이유가 있을까요? 서로 다른 테이블이라 크게 상관은 없을 거 같긴한데 enum으로 통일하는 것도 좋을 것 같습니다!

PROBLEM_AUTHOR랑 CONTEST_AUTHOR의 role은 삭제해도 될 거 같네요. 저건 Codeforces에서는 필요한 게 맞는데 일반적인 대회 세팅에서는 불필요해 보입니다. 퇴근하고 삭제할게요.

@utilForever utilForever dismissed stale reviews from reddevilmidzy and w8385 via 4f1d61f July 1, 2025 13:53
@utilForever
Copy link
Member Author

PROBLEM_AUTHOR랑 CONTEST_AUTHOR의 role은 string 타입이고, SOLUTION의 role은 enum인데 둘이 다른 타입으로 만든 이유가 있을까요? 서로 다른 테이블이라 크게 상관은 없을 거 같긴한데 enum으로 통일하는 것도 좋을 것 같습니다!

삭제했습니다.

@utilForever utilForever merged commit 9e109d3 into main Jul 1, 2025
4 checks passed
@utilForever utilForever deleted the 29-database-er-diagram branch July 1, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Database ER Diagram 그리기

4 participants