proxy: Access CMS instances through subpaths #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose CogStack ModelServe instances (services listening on port 8000) as subpaths through the proxy, alleviating the need to hardcode host port mappings in the client applications. Instead, requests to `/cms/<service>` are forwarded to `<service>:8000` internally using the Docker DNS resolver. This also allows us to access user-deployed CMS instances through the proxy without any configuration changes. The rest of the services included in the stack (e.g. Grafana, MLflow) are still available through their respective host port mappings. Even though efforts were made to integrate them as subpaths, they are not fully supported at this stage. More specifically, while accessing exact paths through their APIs might be possible, accessing their web interfaces when using subpaths is problematic, due to the way these external services handle redirects. Even though we employ certain heuristics to rewrite local URLs we can't account for all possible cases, e.g. local paths in HTML responses. This is a known limitation that should be addressed in future iterations. Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@ucl.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose CogStack ModelServe instances (services listening on port 8000) as subpaths through the proxy, alleviating the need to hardcode host port mappings in the client applications. Instead, requests to
/cms/<service>are forwarded to<service>:8000internally using the Docker DNS resolver. This also allows us to access user-deployed CMS instances through the proxy without any configuration changes.The rest of the services included in the stack (e.g. Grafana, MLflow) are still available through their respective host port mappings. Even though efforts were made to integrate them as subpaths, they are not fully supported at this stage. More specifically, while accessing exact paths through their APIs might be possible, accessing their web interfaces when using subpaths is problematic, due to the way these external services handle redirects. Even though we employ certain heuristics to rewrite local URLs we can't account for all possible cases, e.g. local paths in HTML responses. This is a known limitation that should be addressed in future iterations.