train: Return MLflow tracking information #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoevos
force-pushed
the
feature-phoevos-api-mlflow-refs
branch
from
44af9da to
fb1d335
Compare
Extend the API to return MLflow tracking information as part of a training or evaluation response, including the experiment and run IDs, and update the tests accordingly. If training is already in progress, the API returns the experiment and run IDs of the current training run. This affects the following routes: * POST /train_supervised * POST /train_unsupervised * POST /train_unsupervised_with_hf_hub_dataset * POST /train_metacat * POST /evaluate Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@ucl.ac.uk>
phoevos
force-pushed
the
feature-phoevos-api-mlflow-refs
branch
from
a3bfe83 to
b90b33f
Compare
baixiac
approved these changes
Jan 6, 2025
Member
baixiac
left a comment
baixiac
left a comment
There was a problem hiding this comment.
LGTM. Might be a good time to introduce a new domain class for training responses which now carry more information (instead of returning boo, str, str, return a TrainingResponse obj).
Member
Author
Agreed! Let's reiterate on this once we have the complete picture of how the response will be used by the upstream application (might need to add more info there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the API to return MLflow tracking information as part of a training or evaluation response, including the experiment and run IDs, and update the tests accordingly. If training is already in progress, the API returns the experiment and run IDs of the current training run. This affects the following routes: