RelCAT tutorials v1 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-r
requested changes
May 12, 2025
Collaborator
mart-r
left a comment
mart-r
left a comment
There was a problem hiding this comment.
A few things withuot going too deep initially:
- We don't generally want to install based on the repo dev state but rather install an actual release through PyPI
- Refering to install in 6.1
- Seems fine (though commented by default) in 6.2
- Would be useful to add links to the README as well
- Similar to the other ones
- Would be nice to be able to add this to the workflow as well
.github/workflows/main.yml- Add as another part
- So that we know that this actually works every time we make chagnes to this or the library
Member
Author
|
Ok I updated everything. I put release 1.16.0 so it will pass the workflows when the new MedCAT version gets released. |
pydantic was dropped as a requirement in nbmake==1.4.3
…Ttutorials into rel_cat_tutorials
This reverts commit 957fae8.
alhendrickson
pushed a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jul 1, 2025
* RelCAT tutorials v1. * Updated RelCAT notebooks (incl html version). * Updated README.md * Workflow update to incl RelCAT. * Update MedCAT requirement to 1.16 * Allow nbmake>=1.4 for compatibility with pydantic 2. pydantic was dropped as a requirement in nbmake==1.4.3 * Make workflow run on ubuntu-24.04 * Bump all install targets to 1.16 * Updated RelCAT tutorial to include tutorial model links. * Allow later pandas versions * Revert "Allow later pandas versions" This reverts commit e794964. * Force usage of full path for model * Add some debug information regarding issues when loading model * Do archive unpack in pytho nrather than in a subprocess * Unpack model in part 6.2 to a distinct path * Undo debug output / exception handling * Make sure to use correct paths when downloading and unzipping * Remove unused import * Use relative paths again for downloaded model * Fix usage of undefined variable * Fix loadable model path * Add further information to exception * Specfiy unzip path explicitly --------- Co-authored-by: mart-r <mart.ratas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first version of these tutorials. I'm pretty sure we will need more complex ones if we aim to demo the full pipeline in one go.
Missing from these tutorials: