Skip to content

Conversation

@tomolopolis
Copy link
Member

Extra fields needed for MedCATtery model registry project

@tomolopolis tomolopolis changed the title CU-869a5rv2z: Extra fields for MedCATtery feat(medcat-trainer): CU-869a5rv2z: Extra fields for MedCATtery Aug 18, 2025
Copy link
Collaborator

@mart-r mart-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright.

Though "this version" of the trainer client is within the v2-specific trainer. There's another one in v1-specific one:
https://github.com/CogStack/cogstack-nlp/tree/main/v1/medcat-trainer/client

With that said, the client seems to actually be version agnostic. But there's a separate release workflow for either. Though they would end up in once place.

It may make sense to remove the v1/medcat-trainer/client? So that it's clear which one we're working on and so that we don't need to work on both in parallel? Or perhaps extract the client into its own folder separate from trainer altogether?
Definitely outside the scope of this PR, but just something worth noting.

@tomolopolis
Copy link
Member Author

ah yeah - this is a really good point. I think just easier to remove the client from v1 trainer, rather than maintaining both / or having an old implementation elsewhere.

@tomolopolis tomolopolis merged commit 8e2ebfc into main Aug 18, 2025
8 checks passed
@tomolopolis tomolopolis deleted the medcattrainer/improve-mctproject-client-models branch August 18, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants