Skip to content

bug(medcat-service): DeID bulk processing fix #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 22, 2025
Merged

bug(medcat-service): DeID bulk processing fix #104

merged 16 commits into from
Aug 22, 2025

Conversation

@alhendrickson
Copy link
Collaborator

@alhendrickson alhendrickson commented Aug 20, 2025 •
edited
Loading

Bugs fixed:

  • deid_multi_texts was renamed in medcat2 so missing here
  • Bulk Process for DeID passed the wrong data format to deid_multi_text
  • Bulk process flow never appeared to read the result of deid_multi_texts, instead it just returned the input with no deid

Things to do in a later PR:

  • Rename back to deid_multi_texts
  • Make deid_multi_text also return the annotations
  • Make service bulk process flow more explicit

@alhendrickson alhendrickson marked this pull request as ready for review August 20, 2025 16:07
@mart-r mart-r mentioned this pull request Aug 21, 2025
Merged
mart-r
mart-r approved these changes Aug 22, 2025
View reviewed changes
Copy link
Collaborator

@mart-r mart-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor gripes. But looks good to me overall!

@alhendrickson alhendrickson merged commit 98a6cea into main Aug 22, 2025
20 checks passed
@alhendrickson alhendrickson deleted the bug/medcat-service/deid-bulk-process branch August 22, 2025 09:57
@alhendrickson
Copy link
Collaborator Author

alhendrickson commented Aug 22, 2025

Some minor gripes. But looks good to me overall!

Cheers - I've fixed all these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mart-r mart-r mart-r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alhendrickson @mart-r