Update release tag #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Not going this route |
parsa-hemmati
pushed a commit
to parsa-hemmati/cogstack-nlp
that referenced
this pull request
Nov 21, 2025
…t tasks Changes: - Deployed post-commit-agent-loop-v2.sh (bug fixes) - Backed up v1 as post-commit-agent-loop-v1-backup.sh - Reset TASK_QUEUE.md with 6 fresh unclaimed tasks (CogStack#7-12) Bug Fixes in v2: 1. Task ID parsing: Added head -1 and tr -d '\n' to remove newlines 2. Agent counting: Ensured clean integer output (no embedded newlines) 3. sed regex: Simplified pattern with proper escaping for special chars 4. Concurrent spawning: Added nested loop to spawn multiple agents per commit Test Configuration: - 3 developer tasks (CogStack#7, CogStack#8, CogStack#9) - 1 debugger task (CogStack#10) - 1 tester task (CogStack#11) - 1 documentation task (CogStack#12) Expected Outcome: - All 6 agents should spawn concurrently on this commit - Verifies max_total_agents=6 limit works - Validates per-agent limits (developer=3, tester=1, etc.) Validation: - Check .claude/logs/agent-loop.log for spawn messages - Verify TASK_QUEUE.md shows all 6 tasks claimed [🔄] - Confirm no error messages in post-commit output
parsa-hemmati
pushed a commit
to parsa-hemmati/cogstack-nlp
that referenced
this pull request
Nov 21, 2025
…ning
Critical Fixes:
1. **grep count bug**: Changed 'grep -c ... || echo 0' to 'grep -c ... || true'
- Root cause: grep -c returns 0 when no matches, then || triggers echo 0
- Result: '0\n0' instead of clean '0'
- Fix: Use || true with ${count:-0} fallback
2. **local outside function**: Removed 'local' declarations from main body
- Error: 'local: can only be used in a function' on line 252
- Fix: Changed to regular variable assignments
3. **Integer expression errors**: Added ${var:-0} fallbacks in all comparisons
- Ensures empty or malformed values default to 0
- Applied in check_completion(), check_deadlock(), main loop
4. **Kept v2 improvements**:
- Task ID parsing: head -1 | tr -d '\n'
- sed escaping for special characters (emojis)
- Nested loop structure for concurrent spawning
- Per-agent instance limits
Test Configuration:
- 6 unclaimed tasks (CogStack#7-12) in TASK_QUEUE.md
- 3 developer, 1 debugger, 1 tester, 1 documentation
- Should spawn all 6 agents concurrently on this commit
Expected Output:
[INFO] Active agents: 0 / 6
[INFO] Claimed task CogStack#7 for developer
[INFO] Agent developer spawned (PID: XXXX, task CogStack#7)
[INFO] Claimed task CogStack#8 for developer
[INFO] Agent developer spawned (PID: XXXX, task CogStack#8)
[INFO] Claimed task CogStack#9 for developer
[INFO] Agent developer spawned (PID: XXXX, task CogStack#9)
[INFO] Claimed task CogStack#10 for debugger
[INFO] Agent debugger spawned (PID: XXXX, task CogStack#10)
[INFO] Claimed task CogStack#11 for tester
[INFO] Agent tester spawned (PID: XXXX, task CogStack#11)
[INFO] Claimed task CogStack#12 for documentation
[INFO] Agent documentation spawned (PID: XXXX, task CogStack#12)
[INFO] Post-commit complete. Spawned: 6, Total active: 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will use
medcat-v<major>.<minor>.<patch>for release tag instead ofmedcat/v<major>.<minor>.<patch>.Fix on the workflow step as well as on the release scripts.